On 2023/2/24 03:28, John Keeping wrote:

ft_board_setup() should be availble for use in board files but using it in the rk3288 machine file blocks this functionality.

ft_system_setup() is the more appropriate function to use in a machine definition.

Signed-off-by: John Keeping john@metanate.com

Reviewed-by: Kever Yang kever.yang@rock-chips.com

Thanks, - Kever

---

arch/arm/mach-rockchip/Kconfig | 2 +- arch/arm/mach-rockchip/rk3288/rk3288.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index b678ec41318..3fbfd1b1564 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -119,7 +119,7 @@ config ROCKCHIP_RK322X config ROCKCHIP_RK3288 bool "Support Rockchip RK3288" select CPU_V7A

• select OF_BOARD_SETUP

• select OF_SYSTEM_SETUP select SKIP_LOWLEVEL_INIT_ONLY select SUPPORT_SPL select SPL

diff --git a/arch/arm/mach-rockchip/rk3288/rk3288.c b/arch/arm/mach-rockchip/rk3288/rk3288.c index 3ad2887575d..26c7e41cd89 100644 --- a/arch/arm/mach-rockchip/rk3288/rk3288.c +++ b/arch/arm/mach-rockchip/rk3288/rk3288.c @@ -138,7 +138,7 @@ static int ft_rk3288w_setup(void *blob) return ret; }

-int ft_board_setup(void *blob, struct bd_info *bd) +int ft_system_setup(void *blob, struct bd_info *bd) { if (soc_is_rk3288w()) return ft_rk3288w_setup(blob);