Hi Jagan

From: Bin Meng [mailto:bmeng.cn@gmail.com] Sent: Monday, June 22, 2020 9:53 PM To: Jagan Teki Cc: Rick Jian-Zhi Chen(陳建志); Atish Patra; Palmer Dabbelt; Paul Walmsley; Anup Patel; Sagar Kadam; U-Boot Mailing List; linux-amarula Subject: Re: [PATCH v3 2/6] sifive: fu540: Add Booting from SPI

On Fri, Jun 5, 2020 at 4:40 AM Jagan Teki jagan@amarulasolutions.com wrote:

...

Add booting from SPI for SiFive Unleashed board.

Signed-off-by: Jagan Teki jagan@amarulasolutions.com

Changes for v3:

• updated based on master

arch/riscv/cpu/fu540/Kconfig | 2 + .../dts/hifive-unleashed-a00-u-boot.dtsi | 12 ++++++ configs/sifive_fu540_defconfig | 4 ++ doc/board/sifive/fu540.rst | 41 +++++++++++++++++++ 4 files changed, 59 insertions(+)

diff --git a/arch/riscv/cpu/fu540/Kconfig b/arch/riscv/cpu/fu540/Kconfig index e9302e87c0..7a813a9ac8 100644 --- a/arch/riscv/cpu/fu540/Kconfig +++ b/arch/riscv/cpu/fu540/Kconfig @@ -5,6 +5,8 @@ config SIFIVE_FU540 bool select ARCH_EARLY_INIT_R

•   imply BOARD
  

•   imply BOARD_FU540
  

These 2 are not needed in v3.

How is your opinion here ?

...

    imply CPU
    imply CPU_RISCV
    imply RISCV_TIMER

diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi index 303806454b..4b2b242deb 100644 --- a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi @@ -12,6 +12,10 @@ spi2 = &qspi2; };

•   config {
  

•           u-boot,spl-payload-offset = <0x105000>; /* loader2 @1044KB */
  

•   };
  

•   hfclk {
            u-boot,dm-spl;
    };
  

@@ -22,6 +26,14 @@

};

+&qspi0 {

•   u-boot,dm-spl;
  

•   flash@0 {
  

•           u-boot,dm-spl;
  

•   };
  

+};

&qspi2 { mmc@0 { u-boot,dm-spl;

Other than above, Reviewed-by: Bin Meng bin.meng@windriver.com Tested-by: Bin Meng bin.meng@windriver.com