[U-Boot] [PATCH][MPC8272ADS]

When trying to compile and boot from u-boot (after make distclean ; make MPC8272ADS_config ; make), I had these three errors:
Loading Device Tree to 007fb000, end 007ff159 ... OK Unable to update property /cpus/cpu@0:bus-frequency, err=FDT_ERR_NOTFOUND Unable to update property /cpus/cpu@0:timebase-frequency, err=FDT_ERR_NOTFOUND Unable to update property /cpus/cpu@0:clock-frequency, err=FDT_ERR_NOTFOUND
When looking at the include/configs/MPC8260ADS.h file, the OF_CPU was set to "cpu@0". In the linux kernel, the dts file in arch/powerpc/boot/dts/mpc8272ads.dts contains "PowerPC,8272@0".
Here is the little patch I am proposing in order to correct this issue for the MPC8272ADS board.
Best Regards. JM
---------------------------------------------------------------
--- a/include/configs/MPC8260ADS.h +++ b/include/configs/MPC8260ADS.h
@@ -200,7 +200,11 @@ #define CONFIG_OF_LIBFDT 1 #define CONFIG_OF_BOARD_SETUP 1 #if defined(CONFIG_OF_LIBFDT) +#ifdef CONFIG_MPC8272 +#define OF_CPU "PowerPC,8272@0" +#else #define OF_CPU "cpu@0" +#endif #define OF_TBCLK (bd->bi_busfreq / 4) #endif

On Thu, Jan 15, 2009 at 04:21:18PM +0100, Jean-Michel Hautbois wrote:
--- a/include/configs/MPC8260ADS.h +++ b/include/configs/MPC8260ADS.h
@@ -200,7 +200,11 @@ #define CONFIG_OF_LIBFDT 1 #define CONFIG_OF_BOARD_SETUP 1 #if defined(CONFIG_OF_LIBFDT) +#ifdef CONFIG_MPC8272 +#define OF_CPU "PowerPC,8272@0" +#else #define OF_CPU "cpu@0" +#endif #define OF_TBCLK (bd->bi_busfreq / 4) #endif
Can we just look for device_type == cpu, or for children of the cpus node? The above will break on things like 8248 chips, which use CONFIG_MPC8272.
Or, we could just fix the device trees to use cpu@0.
-Scott
participants (2)
-
Jean-Michel Hautbois
-
Scott Wood