Hi,

On 25 September 2014 21:22, Chao Fu B44548@freescale.com wrote:

From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass Sent: 2014年9月20日 0:25 To: Fu Chao-B44548 Cc: Albert ARIBAUD; Jagannadha Sutradharudu Teki; Stefano Babic; Jagan Teki; Jin Zhengxiong-R64188; U-Boot Mailing List Subject: Re: [PATCH v4 1/3] spi:rewrite the Freescale DSPI driver.

Hi,

On 18 September 2014 23:31, Chao Fu b44548@freescale.com wrote:

From: Chao Fu B44548@freescale.com

Freescale DSPI module is used on both the ColdFire platform and the ARM platform. The original DSPI driver is written for ColdFire platform only, this patch rewrite the driver to make it be used across the platforms. Some files, functions, variables and macros were changed accordingly for some ColdFire boards and Arm boards. The rewrite including the following changes:

If you are doing this, would it not be better to target driver model instead? The current SPI implementation is at u-boot-dm.git branch 'working', although there are patches on the list also.

Regards,

Simon

[Chao Fu]

Thank you, Simon.

My patch also can be applied at u-boot-dm.git branch working correctly.

I think the driver model has not been changed at this once of rewriting.

If you see the 'spi-working' branch you will find the SPI implementation for driver model. There is also a doc there in doc/driver-model showing how to convert a driver over.

The purpose of my patch is making the same module(DSPI) adapt of different platforms. Just rename some details and some support for these platforms.

OK

Regards, Simon