Hi All,
WARNING: do not add new typedefs #64: FILE: arch/arm/include/asm/arch-at91/at91_shdwn.h:19: +typedef struct at91_shdwn {
total: 0 errors, 1 warnings, 45 lines checked
xx has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
I assume that "rule" does not apply to u-boot, and such warnings can be ignored?
However why would typedefs be discouraged in kernel?
Reinhard
Dear Reinhard Meyer,
In message 4CCD305D.50600@emk-elektronik.de you wrote:
Hi All,
WARNING: do not add new typedefs #64: FILE: arch/arm/include/asm/arch-at91/at91_shdwn.h:19: +typedef struct at91_shdwn {
total: 0 errors, 1 warnings, 45 lines checked
xx has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
I assume that "rule" does not apply to u-boot, and such warnings can be ignored?
No.
However why would typedefs be discouraged in kernel?
Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Best regards,
Wolfgang Denk
Dear Reinhard Meyer,
In message 4CCD3AAB.7040705@emk-elektronik.de you wrote:
Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Since no clause, not even (c) applies, I guess *ALL* at91 header files and drivers using them need a rework...
Not really.
Just don't add new ones.
Best regards,
Wolfgang Denk
participants (2)
-
Reinhard Meyer -
Wolfgang Denk