[PATCH 1/1] test/py: Fix broken 'notbuildconfigspec' marker

Consider the following test sample:
@pytest.mark.buildconfigspec('fit') @pytest.mark.notbuildconfigspec('generate_acpi_table') def test_sample(u_boot_console):
Whatever the argument of the 'notbuildconfigspec' is, the test ends up being skipped with the message:
('/uboot/test/py/conftest.py', 463, 'Skipped: .config feature "fit" enabled')
Signed-off-by: Cristian Ciocaltea cristian.ciocaltea@gmail.com --- test/py/conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/py/conftest.py b/test/py/conftest.py index bffee6b8a3..c7f361f7bf 100644 --- a/test/py/conftest.py +++ b/test/py/conftest.py @@ -457,7 +457,7 @@ def setup_buildconfigspec(item): option = options.args[0] if not ubconfig.buildconfig.get('config_' + option.lower(), None): pytest.skip('.config feature "%s" not enabled' % option.lower()) - for option in item.iter_markers('notbuildconfigspec'): + for options in item.iter_markers('notbuildconfigspec'): option = options.args[0] if ubconfig.buildconfig.get('config_' + option.lower(), None): pytest.skip('.config feature "%s" enabled' % option.lower())

On 12/24/19 8:19 AM, Cristian Ciocaltea wrote:
Consider the following test sample:
@pytest.mark.buildconfigspec('fit') @pytest.mark.notbuildconfigspec('generate_acpi_table') def test_sample(u_boot_console):
Whatever the argument of the 'notbuildconfigspec' is, the test ends up being skipped with the message:
('/uboot/test/py/conftest.py', 463, 'Skipped: .config feature "fit" enabled')
Reviewed-by: Stephen Warren swarren@wwwdotorg.org

On 12/24/19 7:28 PM, Stephen Warren wrote:
On 12/24/19 8:19 AM, Cristian Ciocaltea wrote:
Consider the following test sample:
@pytest.mark.buildconfigspec('fit') @pytest.mark.notbuildconfigspec('generate_acpi_table') def test_sample(u_boot_console):
Whatever the argument of the 'notbuildconfigspec' is, the test ends up being skipped with the message:
('/uboot/test/py/conftest.py', 463, 'Skipped: .config feature "fit" enabled')
Reviewed-by: Stephen Warren swarren@wwwdotorg.org
Hello Tom,
please, consider the patch for the upcoming release.
Reviewed-by: Heinrich Schuchardt xypron.glpk@gmx.de
participants (3)
-
Cristian Ciocaltea
-
Heinrich Schuchardt
-
Stephen Warren