[U-Boot] [PATCH v2] mx6cuboxi: Skip usb initialization when booting without HDMI

Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.
However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.
Signed-off-by: Jon Nettleton jon.nettleton@gmail.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- Changes since v1: - Improve commit log (avoid repeating the word 'use').
include/configs/mx6cuboxi.h | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h index 4e07f59..b6f9d4e 100644 --- a/include/configs/mx6cuboxi.h +++ b/include/configs/mx6cuboxi.h @@ -80,6 +80,7 @@ #define CONFIG_VIDEO_LOGO #define CONFIG_VIDEO_BMP_LOGO #define CONFIG_IMX_HDMI +#define CONFIG_CMD_HDMIDETECT #define CONFIG_IMX_VIDEO_SKIP #define CONFIG_CONSOLE_MUX
@@ -94,7 +95,17 @@ #define CONFIG_USB_MAX_CONTROLLER_COUNT 2 #define CONFIG_USB_KEYBOARD #define CONFIG_SYS_USB_EVENT_POLL -#define CONFIG_PREBOOT "usb start" +#define CONFIG_PREBOOT \ + "if hdmidet; then " \ + "usb start; " \ + "setenv stdin serial,usbkbd; "\ + "setenv stdout serial,vga; " \ + "setenv stderr serial,vga; " \ + "else " \ + "setenv stdin serial; " \ + "setenv stdout serial; " \ + "setenv stderr serial; " \ + "fi;"
#define CONFIG_SYS_NO_FLASH
@@ -117,9 +128,6 @@
#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG #define CONFIG_EXTRA_ENV_SETTINGS \ - "stdin=serial,usbkbd\0" \ - "stdout=serial,vga\0" \ - "stderr=serial,vga\0" \ "script=boot.scr\0" \ "image=zImage\0" \ "fdtfile=undefined\0" \

On 2015-05-04, Fabio Estevam wrote:
Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.
However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.
Signed-off-by: Jon Nettleton jon.nettleton@gmail.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Changes since v1:
- Improve commit log (avoid repeating the word 'use').
include/configs/mx6cuboxi.h | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h index 4e07f59..b6f9d4e 100644 --- a/include/configs/mx6cuboxi.h +++ b/include/configs/mx6cuboxi.h @@ -80,6 +80,7 @@ #define CONFIG_VIDEO_LOGO #define CONFIG_VIDEO_BMP_LOGO #define CONFIG_IMX_HDMI +#define CONFIG_CMD_HDMIDETECT #define CONFIG_IMX_VIDEO_SKIP #define CONFIG_CONSOLE_MUX
@@ -94,7 +95,17 @@ #define CONFIG_USB_MAX_CONTROLLER_COUNT 2 #define CONFIG_USB_KEYBOARD #define CONFIG_SYS_USB_EVENT_POLL -#define CONFIG_PREBOOT "usb start" +#define CONFIG_PREBOOT \
- "if hdmidet; then " \
"usb start; " \
"setenv stdin serial,usbkbd; "\
"setenv stdout serial,vga; " \
"setenv stderr serial,vga; " \
- "else " \
"setenv stdin serial; " \
"setenv stdout serial; " \
"setenv stderr serial; " \
- "fi;"
#define CONFIG_SYS_NO_FLASH
@@ -117,9 +128,6 @@
#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG #define CONFIG_EXTRA_ENV_SETTINGS \
- "stdin=serial,usbkbd\0" \
- "stdout=serial,vga\0" \
- "stderr=serial,vga\0" \ "script=boot.scr\0" \ "image=zImage\0" \ "fdtfile=undefined\0" \
-- 1.9.1
Tested-By: Vagrant Cascadian vagrant@aikidev.net

Hi Stefano,
On Mon, May 4, 2015 at 3:18 PM, Vagrant Cascadian vagrant@aikidev.net wrote:
On 2015-05-04, Fabio Estevam wrote:
Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.
However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.
Signed-off-by: Jon Nettleton jon.nettleton@gmail.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Tested-By: Vagrant Cascadian vagrant@aikidev.net
Could this one be applied?
Thanks,
Fabio Estevam

Hi Fabio,
On 11/05/2015 18:47, Fabio Estevam wrote:
Hi Stefano,
On Mon, May 4, 2015 at 3:18 PM, Vagrant Cascadian vagrant@aikidev.net wrote:
On 2015-05-04, Fabio Estevam wrote:
Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.
However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.
Signed-off-by: Jon Nettleton jon.nettleton@gmail.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Tested-By: Vagrant Cascadian vagrant@aikidev.net
Could this one be applied?
Yes !
Applied to u-boot-imx.
Best regards, Stefano Babic
participants (4)
-
Fabio Estevam
-
Fabio Estevam
-
Stefano Babic
-
Vagrant Cascadian