[U-Boot-Users] [PATCH] get_vfatname
Hi,
I find a problem related to the get_vfatname function. This is my proposal patch.
Regards Michael
In message 47EB9C97.8030000@gandalf.sssup.it you wrote:
I find a problem related to the get_vfatname function. This is my proposal patch.
What exactly is the preoblem? Is there a test case that can reproduce the problem?
Best regards,
Wolfgang Denk
Hi, Wolfgang Denk wrote:
In message 47EB9C97.8030000@gandalf.sssup.it you wrote:
I find a problem related to the get_vfatname function. This is my proposal patch.
What exactly is the preoblem? Is there a test case that can reproduce the problem?
My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.
The problem is that the code doesn't look if the dir_slot contain a long name. If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.
Regards Michael
Hi, Wolfgang Denk wrote:
In message 47EB9C97.8030000@gandalf.sssup.it you wrote:
I find a problem related to the get_vfatname function. This is my proposal patch.
What exactly is the preoblem? Is there a test case that can reproduce the problem?
My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.
The problem is that the code doesn't look if the dir_slot contain a long name. If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.
Regards Michael
In message 47ECD868.3040600@gandalf.sssup.it you wrote:
What exactly is the preoblem? Is there a test case that can reproduce the problem?
My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.
The problem is that the code doesn't look if the dir_slot contain a long name. If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.
Well, maybe you can give me a test case?
Like some script to create the needed directories / files in a VFAT file system which provokes the error?
Best regards,
Wolfgang Denk
Wolfgang Denk wrote:
In message 47ECD868.3040600@gandalf.sssup.it you wrote:
What exactly is the preoblem? Is there a test case that can reproduce the problem?
My test case is a 64Mb CF. Maybe I give you a link :) as soon as possible.
The problem is that the code doesn't look if the dir_slot contain a long name. If doesn't contain a long name is a dir_entry and the name can be get by the get_name function. I'm not an expert of vfat filesystem, I take a look to the linux code and to experimental result. The block that is read by the gc_getcluster function is not a dir_slot but a dir_entry.
Well, maybe you can give me a test case?
Like some script to create the needed directories / files in a VFAT file system which provokes the error?
Best regards,
Wolfgang Denk
I can give you an image that you can write on ide disk or on a Compact Flash. Is ok?
Michael
In message 47F22032.6040409@gandalf.sssup.it you wrote:
Like some script to create the needed directories / files in a VFAT file system which provokes the error?
...
I can give you an image that you can write on ide disk or on a Compact Flash. Is ok?
Actually I'd prefer a script to create such an image, but if this is impossible (?) then an image will do, too.
Best regards,
Wolfgang Denk
Hi, Wolfgang Denk wrote:
In message 47F22032.6040409@gandalf.sssup.it you wrote:
Like some script to create the needed directories / files in a VFAT file system which provokes the error?
...
I can give you an image that you can write on ide disk or on a Compact Flash. Is ok?
Actually I'd prefer a script to create such an image, but if this is impossible (?) then an image will do, too.
Do you receive the link?
Regards Michael
participants (2)
-
michael -
Wolfgang Denk