[U-Boot] [PATCH] usb: ulpi: kconfig: Remove meaningless choice default
'default' on a choice refers to the symbol selected by default, not to the choice mode, so 'default n' is meaningless.
No functional changes. Optional choices implicitly default to n mode (and there is no way to make them default to another mode).
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which prints the following warning:
warning: the default selection n (undefined) of <choice> (defined at drivers/usb/ulpi/Kconfig:3) is not contained in the choice
I've added a corresponding warning to the C tools too, which is currently in linux-next: https://patchwork.kernel.org/patch/9983667/
Signed-off-by: Ulf Magnusson ulfalizer@gmail.com --- drivers/usb/ulpi/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig index 329d2df3ed..001564d40c 100644 --- a/drivers/usb/ulpi/Kconfig +++ b/drivers/usb/ulpi/Kconfig @@ -3,7 +3,6 @@ comment "ULPI drivers" choice prompt "ULPI Viewport type" optional - default n help Select ULPI viewport (SoC-side interface to ULPI) implementation appropriate for the device if you want to communicate with
On Tue, Jan 30, 2018 at 02:07:05PM +0100, Ulf Magnusson wrote:
'default' on a choice refers to the symbol selected by default, not to the choice mode, so 'default n' is meaningless.
No functional changes. Optional choices implicitly default to n mode (and there is no way to make them default to another mode).
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which prints the following warning:
warning: the default selection n (undefined) of <choice> (defined at drivers/usb/ulpi/Kconfig:3) is not contained in the choice
I've added a corresponding warning to the C tools too, which is currently in linux-next: https://patchwork.kernel.org/patch/9983667/
Signed-off-by: Ulf Magnusson ulfalizer@gmail.com
Applied to u-boot/master, thanks!
participants (2)
-
Tom Rini -
Ulf Magnusson