[U-Boot] [PATCH] part: Drop duplication declaration of block_dev_desc_t
This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.
Signed-off-by: Simon Glass sjg@chromium.org ---
include/part.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/part.h b/include/part.h index 4d00e22..dc23949 100644 --- a/include/part.h +++ b/include/part.h @@ -10,8 +10,6 @@ #include <ide.h> #include <common.h>
-typedef struct block_dev_desc block_dev_desc_t; - struct block_dev_desc { int if_type; /* type of the interface */ int dev; /* device number */
On Thu, Jan 21, 2016 at 11:12 AM, Simon Glass sjg@chromium.org wrote:
This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.
Signed-off-by: Simon Glass sjg@chromium.org
include/part.h | 2 -- 1 file changed, 2 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
On 21.01.16 04:12, Simon Glass wrote:
This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.
Signed-off-by: Simon Glass sjg@chromium.org
Reviewed-by: Andreas Bießmann andreas.devel@googlemail.com
This fixes buildman breakage for avr32
include/part.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/part.h b/include/part.h index 4d00e22..dc23949 100644 --- a/include/part.h +++ b/include/part.h @@ -10,8 +10,6 @@ #include <ide.h> #include <common.h>
-typedef struct block_dev_desc block_dev_desc_t;
struct block_dev_desc { int if_type; /* type of the interface */ int dev; /* device number */
On Wed, Jan 20, 2016 at 08:12:07PM -0700, Simon Glass wrote:
This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.
Signed-off-by: Simon Glass sjg@chromium.org Reviewed-by: Bin Meng bmeng.cn@gmail.com Reviewed-by: Andreas Bießmann andreas.devel@googlemail.com
Applied to u-boot/master, thanks!
participants (4)
-
Andreas Bießmann -
Bin Meng -
Simon Glass -
Tom Rini