[U-Boot] [PATCH] tegra20: tamonten: Fix the early gpio init
To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.
Signed-off-by: Alban Bedel alban.bedel@avionic-design.de --- board/avionic-design/common/tamonten.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/avionic-design/common/tamonten.c b/board/avionic-design/common/tamonten.c index 9c86779..ea2425a 100644 --- a/board/avionic-design/common/tamonten.c +++ b/board/avionic-design/common/tamonten.c @@ -23,8 +23,10 @@ #ifdef CONFIG_BOARD_EARLY_INIT_F void gpio_early_init(void) { +#ifndef CONFIG_SPL_BUILD gpio_request(GPIO_PI4, NULL); - gpio_direction_output(GPIO_PI4, 1); +#endif + tegra_spl_gpio_direction_output(GPIO_PI4, 1); } #endif
On 02/24/2015 09:58 AM, Alban Bedel wrote:
To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.
Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.
On Tue, 24 Feb 2015 10:02:04 -0700 Stephen Warren swarren@wwwdotorg.org wrote:
On 02/24/2015 09:58 AM, Alban Bedel wrote:
To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.
Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.
This a repost, see [1] for the details. In short this is needed because the GPIO driver isn't available at this point. In October I have been told this will be fixed soon. Now the GPIO driver is still not fixed and all tamonten boards are still broken.
Without this fix all board peripherals are unusable on all Tamonten board, it would be really nice to have this integrated.
Alban
[1] http://lists.denx.de/pipermail/u-boot/2014-October/190464.html
On 02/24/2015 10:18 AM, Alban Bedel wrote:
On Tue, 24 Feb 2015 10:02:04 -0700 Stephen Warren swarren@wwwdotorg.org wrote:
On 02/24/2015 09:58 AM, Alban Bedel wrote:
To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.
Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.
This a repost, see [1] for the details. In short this is needed because the GPIO driver isn't available at this point. In October I have been told this will be fixed soon. Now the GPIO driver is still not fixed and all tamonten boards are still broken.
Without this fix all board peripherals are unusable on all Tamonten board, it would be really nice to have this integrated.
Alban
[1] http://lists.denx.de/pipermail/u-boot/2014-October/190464.html
OK. My point was that the commit description should describe the source of the problem so that anyone looking through git history understands the issues without having to search email lists too.
On Tue, 24 Feb 2015 10:22:52 -0700 Stephen Warren swarren@wwwdotorg.org wrote:
On 02/24/2015 10:18 AM, Alban Bedel wrote:
On Tue, 24 Feb 2015 10:02:04 -0700 Stephen Warren swarren@wwwdotorg.org wrote:
On 02/24/2015 09:58 AM, Alban Bedel wrote:
To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.
Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.
This a repost, see [1] for the details. In short this is needed because the GPIO driver isn't available at this point. In October I have been told this will be fixed soon. Now the GPIO driver is still not fixed and all tamonten boards are still broken.
Without this fix all board peripherals are unusable on all Tamonten board, it would be really nice to have this integrated.
Alban
[1] http://lists.denx.de/pipermail/u-boot/2014-October/190464.html
OK. My point was that the commit description should describe the source of the problem so that anyone looking through git history understands the issues without having to search email lists too.
Right, I'll post a V2 tomorrow with a better log.
Alban
participants (2)
-
Alban Bedel -
Stephen Warren