[PATCH 1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies
CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET. It is sufficient to depend on the prior.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- cmd/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index 4ccb0cef390..02b2569e713 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1685,9 +1685,8 @@ config CMD_ROCKUSB
config CMD_USB_MASS_STORAGE bool "UMS usb mass storage" - depends on USB_GADGET_DOWNLOAD + depends on BLK && USB_GADGET_DOWNLOAD select USB_FUNCTION_MASS_STORAGE - depends on BLK && USB_GADGET help Enables the command "ums" and the USB mass storage support to the export a block device: U-Boot, the USB device, acts as a simple
Hi Heinrich,
Thank you for the patch.
On sam., sept. 21, 2024 at 11:20, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET. It is sufficient to depend on the prior.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
Reviewed-by: Mattijs Korpershoek mkorpershoek@baylibre.com
cmd/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index 4ccb0cef390..02b2569e713 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1685,9 +1685,8 @@ config CMD_ROCKUSB
config CMD_USB_MASS_STORAGE bool "UMS usb mass storage"
- depends on USB_GADGET_DOWNLOAD
- depends on BLK && USB_GADGET_DOWNLOAD select USB_FUNCTION_MASS_STORAGE
- depends on BLK && USB_GADGET help Enables the command "ums" and the USB mass storage support to the export a block device: U-Boot, the USB device, acts as a simple
-- 2.45.2
On 21/09/2024 11:20, Heinrich Schuchardt wrote:
CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET. It is sufficient to depend on the prior.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
Reviewed-by: Caleb Connolly caleb.connolly@linaro.org
cmd/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index 4ccb0cef390..02b2569e713 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1685,9 +1685,8 @@ config CMD_ROCKUSB
config CMD_USB_MASS_STORAGE bool "UMS usb mass storage"
- depends on USB_GADGET_DOWNLOAD
- depends on BLK && USB_GADGET_DOWNLOAD select USB_FUNCTION_MASS_STORAGE
- depends on BLK && USB_GADGET help Enables the command "ums" and the USB mass storage support to the export a block device: U-Boot, the USB device, acts as a simple
Hi,
On Sat, 21 Sep 2024 11:20:50 +0200, Heinrich Schuchardt wrote:
CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET. It is sufficient to depend on the prior.
Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu-next)
[1/1] cmd: simplify CONFIG_CMD_USB_MASS_STORAGE dependencies https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/c74758ccc091402...
-- Mattijs
participants (3)
-
Caleb Connolly -
Heinrich Schuchardt -
Mattijs Korpershoek