[U-Boot] Please pull u-boot-dm
Hi Tom,
Here are some additions to logging and 64-bit sandbox support.
The following changes since commit ab12aa24e619b5e81cbde7de88c6d9a19f04313b:
ARM: socfpga: Convert callers of cm_write_with_phase for wait_for_bit_le32 (2018-01-26 13:08:03 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 4e94617bf911595efcecf52d6c9f323744a81cda:
log: add category LOGC_EFI (2018-01-26 12:20:55 -0700)
---------------------------------------------------------------- Heinrich Schuchardt (1): log: add category LOGC_EFI
Mario Six (1): sandbox: Add 64-bit sandbox
Simon Glass (9): dm: core: Add a function to look up a uclass by name log: Add functions to convert IDs to/from names log: Add control over log formatting log: Update log_console to honour the log format log: Add a command to control the log output format log: Add a command to output a log record log: Add tests for the new log features log: Add documentation for commands and formatting log: Add a way to log error-return values
arch/sandbox/Kconfig | 16 ++- arch/sandbox/cpu/cpu.c | 2 +- arch/sandbox/dts/Makefile | 4 + arch/sandbox/dts/sandbox64.dts | 317 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ arch/sandbox/include/asm/io.h | 6 ++ arch/sandbox/include/asm/types.h | 17 +++- board/sandbox/README.sandbox | 7 +- cmd/demo.c | 6 +- cmd/log.c | 82 +++++++++++++++ common/Kconfig | 13 +++ common/log.c | 69 +++++++++++++ common/log_console.c | 27 ++++- configs/sandbox64_defconfig | 200 ++++++++++++++++++++++++++++++++++++ configs/sandbox_defconfig | 1 + doc/README.log | 36 +++++++ drivers/core/uclass.c | 14 +++ drivers/demo/demo-simple.c | 2 +- include/asm-generic/global_data.h | 1 + include/dm/uclass.h | 8 ++ include/log.h | 65 +++++++++++- test/dm/core.c | 9 ++ test/py/tests/test_log.py | 32 +++++- 22 files changed, 912 insertions(+), 22 deletions(-) create mode 100644 arch/sandbox/dts/sandbox64.dts create mode 100644 configs/sandbox64_defconfig
Regards, Simon
On Fri, Jan 26, 2018 at 02:45:29PM -0700, Simon Glass wrote:
Hi Tom,
Here are some additions to logging and 64-bit sandbox support.
The following changes since commit ab12aa24e619b5e81cbde7de88c6d9a19f04313b:
ARM: socfpga: Convert callers of cm_write_with_phase for wait_for_bit_le32 (2018-01-26 13:08:03 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 4e94617bf911595efcecf52d6c9f323744a81cda:
log: add category LOGC_EFI (2018-01-26 12:20:55 -0700)
NAK: Starting LLVM-3.8 test common/log.c:44:17: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] if (log_uc_cat(cat) >= LOGC_NONE) ~~~~~~~~~~ ^~~ common/log.c:47:36: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] return uclass_get_name(log_uc_cat(cat)); ~~~~~~~~~~ ^~~ 2 warnings generated.
Also, checkpatch.pl notes that the sandbox64 defconfig isn't caught by MAINTAINERS and then I see the 32bit one already isn't.
Finally, I see a bunch of warnings on sandbox64: lib/fdtdec.c: In function ‘fdtdec_get_addr_size_auto_noparent’: include/fdtdec.h:27:25: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define FDT_ADDR_T_NONE (-1ULL)
That's with my normal 64bit host gcc (5.4.0, Ubuntu 16.04).
Thanks!
Hi Tom,
On 26 January 2018 at 17:50, Tom Rini trini@konsulko.com wrote:
On Fri, Jan 26, 2018 at 02:45:29PM -0700, Simon Glass wrote:
Hi Tom,
Here are some additions to logging and 64-bit sandbox support.
The following changes since commit ab12aa24e619b5e81cbde7de88c6d9a19f04313b:
ARM: socfpga: Convert callers of cm_write_with_phase for wait_for_bit_le32 (2018-01-26 13:08:03 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 4e94617bf911595efcecf52d6c9f323744a81cda:
log: add category LOGC_EFI (2018-01-26 12:20:55 -0700)
NAK: Starting LLVM-3.8 test common/log.c:44:17: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] if (log_uc_cat(cat) >= LOGC_NONE) ~~~~~~~~~~ ^~~ common/log.c:47:36: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] return uclass_get_name(log_uc_cat(cat)); ~~~~~~~~~~ ^~~ 2 warnings generated.
Also, checkpatch.pl notes that the sandbox64 defconfig isn't caught by MAINTAINERS and then I see the 32bit one already isn't.
Finally, I see a bunch of warnings on sandbox64: lib/fdtdec.c: In function ‘fdtdec_get_addr_size_auto_noparent’: include/fdtdec.h:27:25: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define FDT_ADDR_T_NONE (-1ULL)
That's with my normal 64bit host gcc (5.4.0, Ubuntu 16.04).
OK I'll drop sandbox64 for now. I'm not sure why buildman was happy, but I may have missed it because there are already a lot of warnings with sandbox. I'll see if I can fix those. I need to add clang to my workflow...
Regards, Simon
On Sat, Feb 03, 2018 at 10:12:41AM -0700, Simon Glass wrote:
Hi Tom,
On 26 January 2018 at 17:50, Tom Rini trini@konsulko.com wrote:
On Fri, Jan 26, 2018 at 02:45:29PM -0700, Simon Glass wrote:
Hi Tom,
Here are some additions to logging and 64-bit sandbox support.
The following changes since commit ab12aa24e619b5e81cbde7de88c6d9a19f04313b:
ARM: socfpga: Convert callers of cm_write_with_phase for wait_for_bit_le32 (2018-01-26 13:08:03 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 4e94617bf911595efcecf52d6c9f323744a81cda:
log: add category LOGC_EFI (2018-01-26 12:20:55 -0700)
NAK: Starting LLVM-3.8 test common/log.c:44:17: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] if (log_uc_cat(cat) >= LOGC_NONE) ~~~~~~~~~~ ^~~ common/log.c:47:36: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] return uclass_get_name(log_uc_cat(cat)); ~~~~~~~~~~ ^~~ 2 warnings generated.
Also, checkpatch.pl notes that the sandbox64 defconfig isn't caught by MAINTAINERS and then I see the 32bit one already isn't.
Finally, I see a bunch of warnings on sandbox64: lib/fdtdec.c: In function ‘fdtdec_get_addr_size_auto_noparent’: include/fdtdec.h:27:25: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define FDT_ADDR_T_NONE (-1ULL)
That's with my normal 64bit host gcc (5.4.0, Ubuntu 16.04).
OK I'll drop sandbox64 for now. I'm not sure why buildman was happy, but I may have missed it because there are already a lot of warnings with sandbox. I'll see if I can fix those. I need to add clang to my workflow...
It's not too hard. Note that if you go newer than 3.8 there's a ton of warnings I haven't had time to look into. And I only test sandbox with clang atm.
Hi Tom,
On 4 February 2018 at 02:13, Tom Rini trini@konsulko.com wrote:
On Sat, Feb 03, 2018 at 10:12:41AM -0700, Simon Glass wrote:
Hi Tom,
On 26 January 2018 at 17:50, Tom Rini trini@konsulko.com wrote:
On Fri, Jan 26, 2018 at 02:45:29PM -0700, Simon Glass wrote:
Hi Tom,
Here are some additions to logging and 64-bit sandbox support.
The following changes since commit ab12aa24e619b5e81cbde7de88c6d9a19f04313b:
ARM: socfpga: Convert callers of cm_write_with_phase for wait_for_bit_le32 (2018-01-26 13:08:03 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 4e94617bf911595efcecf52d6c9f323744a81cda:
log: add category LOGC_EFI (2018-01-26 12:20:55 -0700)
NAK: Starting LLVM-3.8 test common/log.c:44:17: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] if (log_uc_cat(cat) >= LOGC_NONE) ~~~~~~~~~~ ^~~ common/log.c:47:36: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] return uclass_get_name(log_uc_cat(cat)); ~~~~~~~~~~ ^~~ 2 warnings generated.
Also, checkpatch.pl notes that the sandbox64 defconfig isn't caught by MAINTAINERS and then I see the 32bit one already isn't.
Finally, I see a bunch of warnings on sandbox64: lib/fdtdec.c: In function ‘fdtdec_get_addr_size_auto_noparent’: include/fdtdec.h:27:25: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define FDT_ADDR_T_NONE (-1ULL)
That's with my normal 64bit host gcc (5.4.0, Ubuntu 16.04).
OK I'll drop sandbox64 for now. I'm not sure why buildman was happy, but I may have missed it because there are already a lot of warnings with sandbox. I'll see if I can fix those. I need to add clang to my workflow...
It's not too hard. Note that if you go newer than 3.8 there's a ton of warnings I haven't had time to look into. And I only test sandbox with clang atm.
I don't see any warnings doing this:
$ make -s -j10 HOSTCC=clang-3.8 O=b/sandbox/ sandbox_defconfig all $ make -s -j10 HOSTCC=clang-3.8 O=b/sandbox64/ sandbox64_defconfig all $
How do I get the warnings?
Regards Simon
On Mon, Apr 02, 2018 at 02:11:59PM +0800, Simon Glass wrote:
Hi Tom,
On 4 February 2018 at 02:13, Tom Rini trini@konsulko.com wrote:
On Sat, Feb 03, 2018 at 10:12:41AM -0700, Simon Glass wrote:
Hi Tom,
On 26 January 2018 at 17:50, Tom Rini trini@konsulko.com wrote:
On Fri, Jan 26, 2018 at 02:45:29PM -0700, Simon Glass wrote:
Hi Tom,
Here are some additions to logging and 64-bit sandbox support.
The following changes since commit ab12aa24e619b5e81cbde7de88c6d9a19f04313b:
ARM: socfpga: Convert callers of cm_write_with_phase for wait_for_bit_le32 (2018-01-26 13:08:03 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 4e94617bf911595efcecf52d6c9f323744a81cda:
log: add category LOGC_EFI (2018-01-26 12:20:55 -0700)
NAK: Starting LLVM-3.8 test common/log.c:44:17: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] if (log_uc_cat(cat) >= LOGC_NONE) ~~~~~~~~~~ ^~~ common/log.c:47:36: warning: implicit conversion from enumeration type 'enum log_category_t' to different enumeration type 'enum uclass_id' [-Wenum-conversion] return uclass_get_name(log_uc_cat(cat)); ~~~~~~~~~~ ^~~ 2 warnings generated.
Also, checkpatch.pl notes that the sandbox64 defconfig isn't caught by MAINTAINERS and then I see the 32bit one already isn't.
Finally, I see a bunch of warnings on sandbox64: lib/fdtdec.c: In function ‘fdtdec_get_addr_size_auto_noparent’: include/fdtdec.h:27:25: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define FDT_ADDR_T_NONE (-1ULL)
That's with my normal 64bit host gcc (5.4.0, Ubuntu 16.04).
OK I'll drop sandbox64 for now. I'm not sure why buildman was happy, but I may have missed it because there are already a lot of warnings with sandbox. I'll see if I can fix those. I need to add clang to my workflow...
It's not too hard. Note that if you go newer than 3.8 there's a ton of warnings I haven't had time to look into. And I only test sandbox with clang atm.
I don't see any warnings doing this:
$ make -s -j10 HOSTCC=clang-3.8 O=b/sandbox/ sandbox_defconfig all $ make -s -j10 HOSTCC=clang-3.8 O=b/sandbox64/ sandbox64_defconfig all $
How do I get the warnings?
They have been fixed since then, I guess it was something else that was also in that PR at the time? Thanks!
participants (2)
-
Simon Glass -
Tom Rini