[U-Boot] [PATCH] part_efi: Fix partition size calculation due to inclusive ending LBA.

From b24eaf52ade5e5f1e94243f727d4c0f6d0fccdf5 Mon Sep 17 00:00:00 2001
From: Richard Retanubun RichardRetanubun@RuggedCom.com Date: Fri, 12 Dec 2008 10:23:45 -0500 Subject: [PATCH] The ending LBA is inclusive. Hence, the partition size should be ((ending-LBA + 1) - starting-LBA) to get the proper partition size.
This is confirmed against the results from the parted tool. (e.g. use parted /dev/sda -s unit S print) and observe the size.
Signed-off-by: Richard Retanubun RichardRetanubun@RuggedCom.com --- Hi Wolfgang,
Apologies for the 'custodianship' assumption audacity :) Let me know if there is a more proper 'channel' for this and I'll stop bugging you.
disk/part_efi.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/disk/part_efi.c b/disk/part_efi.c index cc188ee..d8a8111 100644 --- a/disk/part_efi.c +++ b/disk/part_efi.c @@ -163,7 +163,9 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
/* The ulong casting limits the maximum disk size to 2 TB */ info->start = (ulong) le64_to_int((*pgpt_pte)[part - 1].starting_lba); - info->size = (ulong) le64_to_int((*pgpt_pte)[part - 1].ending_lba) - info->start; + /* The ending LBA is inclusive, to calculate size, add 1 to it */ + info->size = ((ulong)le64_to_int((*pgpt_pte)[part - 1].ending_lba) + 1) + - info->start; info->blksz = GPT_BLOCK_SIZE;
sprintf((char *)info->name, "%s%d\n", GPT_ENTRY_NAME, part); -- 1.5.6.5

Dear Richard Retanubun,
In message 494286ED.2070207@RuggedCom.com you wrote:
From b24eaf52ade5e5f1e94243f727d4c0f6d0fccdf5 Mon Sep 17 00:00:00 2001 From: Richard Retanubun RichardRetanubun@RuggedCom.com Date: Fri, 12 Dec 2008 10:23:45 -0500 Subject: [PATCH] The ending LBA is inclusive. Hence, the partition size should be ((ending-LBA + 1) - starting-LBA) to get the proper partition size.
This is confirmed against the results from the parted tool. (e.g. use parted /dev/sda -s unit S print) and observe the size.
Signed-off-by: Richard Retanubun RichardRetanubun@RuggedCom.com
Sorry, this does not apply:
Applying: part_efi: Fix partition size calculation due to inclusive ending LBA. error: patch failed: disk/part_efi.c:163 error: disk/part_efi.c: patch does not apply Using index info to reconstruct a base tree... error: patch failed: disk/part_efi.c:163 error: disk/part_efi.c: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. Patch failed at 0001.
Please rebase and resubmit.
Best regards,
Wolfgang Denk

Hello everybody,
Really quick and hopefully easy question:
Does uboot do PCI enumeration in common code or is this task left to the individual board specific code and setup tasks.?
Thanks a lot in advance!!
- Vinay
participants (3)
-
Richard Retanubun
-
Vinay Venkataraghavan
-
Wolfgang Denk