[U-Boot] [PATCH] ARM: dts: socfpga: Add missing altr, sysmgr-syscon for EMAC
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com --- arch/arm/dts/socfpga_stratix10.dtsi | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi index ccd3f32301..ee93725d64 100644 --- a/arch/arm/dts/socfpga_stratix10.dtsi +++ b/arch/arm/dts/socfpga_stratix10.dtsi @@ -95,6 +95,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC0_RESET>, <&rst EMAC0_OCP_RESET>; reset-names = "stmmaceth"; + altr,sysmgr-syscon = <&sysmgr 0x44 0>; status = "disabled"; };
@@ -106,6 +107,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC1_RESET>, <&rst EMAC1_OCP_RESET>; reset-names = "stmmaceth"; + altr,sysmgr-syscon = <&sysmgr 0x48 0>; status = "disabled"; };
@@ -117,6 +119,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC2_RESET>, <&rst EMAC2_OCP_RESET>; reset-names = "stmmaceth"; + altr,sysmgr-syscon = <&sysmgr 0x4c 0>; status = "disabled"; };
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
arch/arm/dts/socfpga_stratix10.dtsi | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi index ccd3f32301..ee93725d64 100644 --- a/arch/arm/dts/socfpga_stratix10.dtsi +++ b/arch/arm/dts/socfpga_stratix10.dtsi @@ -95,6 +95,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC0_RESET>, <&rst EMAC0_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x44 0>; status = "disabled";@@ -106,6 +107,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC1_RESET>, <&rst EMAC1_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x48 0>; status = "disabled";@@ -117,6 +119,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC2_RESET>, <&rst EMAC2_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x4c 0>; status = "disabled";
On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.
Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel.
[ 1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [ 1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22
Regards Ley Foon
arch/arm/dts/socfpga_stratix10.dtsi | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi index ccd3f32301..ee93725d64 100644 --- a/arch/arm/dts/socfpga_stratix10.dtsi +++ b/arch/arm/dts/socfpga_stratix10.dtsi @@ -95,6 +95,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC0_RESET>, <&rst EMAC0_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x44 0>;status = "disabled"; }; @@ -106,6 +107,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC1_RESET>, <&rst EMAC1_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x48 0>;status = "disabled"; }; @@ -117,6 +119,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC2_RESET>, <&rst EMAC2_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x4c 0>;status = "disabled"; };
On 3/13/19 6:59 AM, Ley Foon Tan wrote:
On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.
Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel.
[ 1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [ 1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22
You know what to do :)
Regards Ley Foon
arch/arm/dts/socfpga_stratix10.dtsi | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi index ccd3f32301..ee93725d64 100644 --- a/arch/arm/dts/socfpga_stratix10.dtsi +++ b/arch/arm/dts/socfpga_stratix10.dtsi @@ -95,6 +95,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC0_RESET>, <&rst EMAC0_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x44 0>;status = "disabled"; }; @@ -106,6 +107,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC1_RESET>, <&rst EMAC1_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x48 0>;status = "disabled"; }; @@ -117,6 +119,7 @@ mac-address = [00 00 00 00 00 00]; resets = <&rst EMAC2_RESET>, <&rst EMAC2_OCP_RESET>; reset-names = "stmmaceth";
altr,sysmgr-syscon = <&sysmgr 0x4c 0>;status = "disabled"; };
On 3/13/19 12:59 AM, Ley Foon Tan wrote:
On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.
Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel.
[ 1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [ 1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22
I see this in mainline Linux:
[ 0.911521] socfpga-dwmac ff800000.ethernet: PTP uses main clock [ 0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node found [ 0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 0.930944] stmmaceth ff800000.ethernet: PTP uses main clock [ 0.936723] stmmaceth ff800000.ethernet: User ID: 0x11, Synopsys ID: 0x37 [ 0.943496] stmmaceth ff800000.ethernet: DWMAC1000
It doesn't fail probing though. I'll look into it.
Dinh
On Wed, 2019-03-13 at 09:32 -0500, Dinh Nguyen wrote:
On 3/13/19 12:59 AM, Ley Foon Tan wrote:
On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.
Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel.
[ 1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [ 1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22
I see this in mainline Linux:
[ 0.911521] socfpga-dwmac ff800000.ethernet: PTP uses main clock [ 0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node found [ 0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 0.930944] stmmaceth ff800000.ethernet: PTP uses main clock [ 0.936723] stmmaceth ff800000.ethernet: User ID: 0x11, Synopsys ID: 0x37 [ 0.943496] stmmaceth ff800000.ethernet: DWMAC1000
It doesn't fail probing though. I'll look into it.
Dinh
Why it probes driver twice? One with "socfpga-dwmac", another with "stmmaceth".
There is error "No sysmgr-syscon node found". So, should we add "sysmgr-syscon" dts parameter to dts?
Regards Ley Foon
On 3/13/19 9:32 AM, Dinh Nguyen wrote:
On 3/13/19 12:59 AM, Ley Foon Tan wrote:
On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.
Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel.
[ 1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [ 1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22
It looks like you're running downstream Linux. The failed to probe message is only in the downstream Linux, not upstream Linux.
Dinh
On Wed, 2019-03-13 at 10:33 -0500, Dinh Nguyen wrote:
On 3/13/19 9:32 AM, Dinh Nguyen wrote:
On 3/13/19 12:59 AM, Ley Foon Tan wrote:
On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.
Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel.
[ 1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [ 1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22
It looks like you're running downstream Linux. The failed to probe message is only in the downstream Linux, not upstream Linux.
Dinh
Yes, I am using downstream socfpga-4.20 branch. Upstream Linux can ping IP address successfully?
Regards Ley Foon
On 3/13/19 6:54 AM, Ley Foon Tan wrote:
On Wed, 2019-03-13 at 10:33 -0500, Dinh Nguyen wrote:
On 3/13/19 9:32 AM, Dinh Nguyen wrote:
On 3/13/19 12:59 AM, Ley Foon Tan wrote:
On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
On 3/13/19 4:03 AM, Ley Foon Tan wrote:
Syscon register is required in dts to select correct PHY interface.
Fix error below:
Net: Failed to get syscon: -2
Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com
Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.
Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel.
[ 1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [ 1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [ 1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22
It looks like you're running downstream Linux. The failed to probe message is only in the downstream Linux, not upstream Linux.
Dinh
Yes, I am using downstream socfpga-4.20 branch. Upstream Linux can ping IP address successfully?
I can even mount an NFS. Anyways, I'm sending out a patch shortly.
Dinh
participants (3)
-
Dinh Nguyen -
Ley Foon Tan -
Marek Vasut