[PATCH] doc: coolpi: Fix the defconfig name
The defconfig name should be: coolpi-cm5-genbook-rk3588_defconfig
Signed-off-by: Andy Yan andyshrk@163.com ---
doc/board/coolpi/genbook_cm5_rk3588.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/board/coolpi/genbook_cm5_rk3588.rst b/doc/board/coolpi/genbook_cm5_rk3588.rst index cad2a28acbd..26cddac9207 100644 --- a/doc/board/coolpi/genbook_cm5_rk3588.rst +++ b/doc/board/coolpi/genbook_cm5_rk3588.rst @@ -28,7 +28,7 @@ Get the TF-A and DDR init (TPL) binaries cd u-boot export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.17.bin export BL31=../rkbin/bin/rk35/rk3588_bl31_v1.46.elf - make coolpi-genbook-cm5-rk3588_defconfig + make coolpi-cm5-genbook-rk3588_defconfig make CROSS_COMPILE=aarch64-linux-gnu-
This will build ``u-boot-rockchip.bin`` for eMMC and ``u-boot-rockchip-spi.bin`` for SPI Nor.
Hi Andy,
On 1/13/25 11:56 AM, Andy Yan wrote:
The defconfig name should be: coolpi-cm5-genbook-rk3588_defconfig
Signed-off-by: Andy Yan andyshrk@163.com
Reviewed-by: Quentin Schulz quentin.schulz@cherry.de
doc/board/coolpi/genbook_cm5_rk3588.rst | 2 +-
What about renaming every file that are inconsistent in naming?
board/coolpi/genbook_cm5_rk3588/ to board/coolpi/cm5_genbook_rk3588/ doc/board/coolpi/genbook_cm5_rk3588.rst to doc/board/coolpi/cm5_genbook_rk3588.rst include/configs/genbook-cm5-rk3588.h to include/configs/cm5-genbook-rk3588.h
If we do this change, we also need to change a few variables in Kconfig/defconfig. If we do this change, it needs to be done in a separate patch though!
What do you think?
Cheers, Quentin
Hi Quentin,
At 2025-01-15 17:29:10, "Quentin Schulz" quentin.schulz@cherry.de wrote:
Hi Andy,
On 1/13/25 11:56 AM, Andy Yan wrote:
The defconfig name should be: coolpi-cm5-genbook-rk3588_defconfig
Signed-off-by: Andy Yan andyshrk@163.com
Reviewed-by: Quentin Schulz quentin.schulz@cherry.de
First, thanks for your review.
doc/board/coolpi/genbook_cm5_rk3588.rst | 2 +-
What about renaming every file that are inconsistent in naming?
board/coolpi/genbook_cm5_rk3588/ to board/coolpi/cm5_genbook_rk3588/ doc/board/coolpi/genbook_cm5_rk3588.rst to doc/board/coolpi/cm5_genbook_rk3588.rst include/configs/genbook-cm5-rk3588.h to include/configs/cm5-genbook-rk3588.h
If we do this change, we also need to change a few variables in Kconfig/defconfig. If we do this change, it needs to be done in a separate patch though!
Please check the review records when I first submitted the patch for this board's support[0][1],
As for myself, I can accept both naming conventions. However, different reviewer seem to have different nameing rules.
[0]https://lore.kernel.org/u-boot/20240811100255.1664095-1-andyshrk@163.com/ [1]https://lore.kernel.org/u-boot/e251ab8c-f3d2-489e-a3c8-c7154e96c2e4@kwiboo.s...
What do you think?
Anyway, I think this patch should be merged first to avoid misleading others who want to practice on their own.
Cheers, Quentin
participants (2)
-
Andy Yan -
Quentin Schulz