-----Original Message----- From: Chee, Tien Fong tien.fong.chee@intel.com Sent: Tuesday, 24 May 2022 6:29 pm To: Maniyam, Dinesh dinesh.maniyam@intel.com; u-boot@lists.denx.de Cc: Michal Simek michal.simek@amd.com; Hea, Kok Kiang kok.kiang.hea@intel.com; Gan, Yau Wai yau.wai.gan@intel.com; Kho, Sin Hui sin.hui.kho@intel.com; Lokanathan, Raaj raaj.lokanathan@intel.com; Ley Foon Tan ley.foon.tan@intel.com Subject: RE: [PATCH] fpga: intel_sdm_mb: Add checking for INTEL_SIP_SMC_STATUS_BUSY (1)

...

-----Original Message----- From: Maniyam, Dinesh dinesh.maniyam@intel.com Sent: Monday, 9 May, 2022 3:43 PM To: u-boot@lists.denx.de Cc: Michal Simek michal.simek@amd.com; Chee, Tien Fong tien.fong.chee@intel.com; Hea, Kok Kiang kok.kiang.hea@intel.com; Gan, Yau Wai yau.wai.gan@intel.com; Kho, Sin Hui sin.hui.kho@intel.com; Lokanathan, Raaj raaj.lokanathan@intel.com; Maniyam, Dinesh dinesh.maniyam@intel.com; Ley Foon Tan ley.foon.tan@intel.com Subject: [PATCH] fpga: intel_sdm_mb: Add checking for INTEL_SIP_SMC_STATUS_BUSY (1)

From: Dinesh Maniyam dinesh.maniyam@intel.com

Status busy means transfer is accepted but SDM does not have more freed buffer. It is not an error. Continue process the data if receive OK and BUSY status.

Can you help to improve the commit message? That is not possible wr_ret would return with two results(OK and BUSY) in status at the same time. Please change to "OK or Busy status".

Please extend the years of copyright to "2018-2022"

...

Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com Signed-off-by: Dinesh Maniyam dinesh.maniyam@intel.com

---

drivers/fpga/intel_sdm_mb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/fpga/intel_sdm_mb.c b/drivers/fpga/intel_sdm_mb.c index f5fd9a14c2..5e0b2777e0 100644 --- a/drivers/fpga/intel_sdm_mb.c +++ b/drivers/fpga/intel_sdm_mb.c @@ -70,7 +70,8 @@ static int send_bitstream(const void *rbf_data, size_t rbf_size) debug("wr_ret = %d, rbf_data = %p, buf_size =

%08lx\n",

...

	      wr_ret, rbf_data, buf_size);

• 	if (wr_ret)
  

• 	if (wr_ret != INTEL_SIP_SMC_STATUS_OK &&
  

• 		wr_ret != INTEL_SIP_SMC_STATUS_BUSY)
  

Alignment issue after "(" above, please run the checkpatch.pl

...

		continue;

	rbf_size -= buf_size;

-- 2.26.2

Thanks for the review. V3 patch will have the update for the copyright year, commit message and proper alignment.

From: Dinesh Maniyam dinesh.maniyam@intel.com

Status busy means transfer is accepted but SDM does not have more freed buffer. It is not an error. Continue process the data if receive OK or BUSY status.

Signed-off-by: Dinesh Maniyam dinesh.maniyam@intel.com

---

v2->v3 -Copyright year updated and alignment adjusted. --- drivers/fpga/intel_sdm_mb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/fpga/intel_sdm_mb.c b/drivers/fpga/intel_sdm_mb.c index f5fd9a14c2..44ef7717d0 100644 --- a/drivers/fpga/intel_sdm_mb.c +++ b/drivers/fpga/intel_sdm_mb.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * Copyright (C) 2018 Intel Corporation <www.intel.com> + * Copyright (C) 2018-2022 Intel Corporation <www.intel.com> */

#include <common.h> @@ -70,7 +70,8 @@ static int send_bitstream(const void *rbf_data, size_t rbf_size) debug("wr_ret = %d, rbf_data = %p, buf_size = %08lx\n", wr_ret, rbf_data, buf_size);

- if (wr_ret) + if (wr_ret != INTEL_SIP_SMC_STATUS_OK && + wr_ret != INTEL_SIP_SMC_STATUS_BUSY) continue;

rbf_size -= buf_size;