[PATCH] sql: Kconfig: TPL_BANNER_PRINT depends on DEBUG_UART && TPL_SERIAL
From: Ying Sun sunying@nj.iscas.ac.cn
As implemented in the arch/arm/mach-rockchip/tpl.c file, the CONFIG_TPL_BANNER_PRINT option will not work if either of these options is not enabled.
Add dependency constraints to the CONFIG_TPL_BANNER_PRINT option definition to prevent configuration problems where option is enabled but do not take effect.
Suggested-by: Yanjie Ren renyanjie01@gmail.com Signed-off-by: Ying Sun sunying@nj.iscas.ac.cn --- common/spl/Kconfig.tpl | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl index 1874f9db4f..3d6cf1e59f 100644 --- a/common/spl/Kconfig.tpl +++ b/common/spl/Kconfig.tpl @@ -43,6 +43,7 @@ config TPL_FRAMEWORK
config TPL_BANNER_PRINT bool "Enable output of the TPL banner 'U-Boot TPL ...'" + depends on DEBUG_UART && TPL_SERIAL default y help If this option is enabled, TPL will print the banner with version
On Sun, 25 Jun 2023 at 13:35, sunying@nj.iscas.ac.cn wrote:
From: Ying Sun sunying@nj.iscas.ac.cn
As implemented in the arch/arm/mach-rockchip/tpl.c file, the CONFIG_TPL_BANNER_PRINT option will not work if either of these options is not enabled.
Add dependency constraints to the CONFIG_TPL_BANNER_PRINT option definition to prevent configuration problems where option is enabled but do not take effect.
Suggested-by: Yanjie Ren renyanjie01@gmail.com Signed-off-by: Ying Sun sunying@nj.iscas.ac.cn
common/spl/Kconfig.tpl | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl index 1874f9db4f..3d6cf1e59f 100644 --- a/common/spl/Kconfig.tpl +++ b/common/spl/Kconfig.tpl @@ -43,6 +43,7 @@ config TPL_FRAMEWORK
config TPL_BANNER_PRINT bool "Enable output of the TPL banner 'U-Boot TPL ...'"
depends on DEBUG_UART && TPL_SERIAL
I don't think it should depend on DEBUG_UART since it is possible to enable the normal UART in TPL. TPL_SERIAL looks right though.
Perhaps the condition should be || ?
default y help If this option is enabled, TPL will print the banner with version-- 2.17.1
Regards, Simon
On Sun, Jun 25, 2023 at 05:18:21PM +0800, sunying@nj.iscas.ac.cn wrote:
From: Ying Sun sunying@nj.iscas.ac.cn
As implemented in the arch/arm/mach-rockchip/tpl.c file, the CONFIG_TPL_BANNER_PRINT option will not work if either of these options is not enabled.
Add dependency constraints to the CONFIG_TPL_BANNER_PRINT option definition to prevent configuration problems where option is enabled but do not take effect.
Suggested-by: Yanjie Ren renyanjie01@gmail.com Signed-off-by: Ying Sun sunying@nj.iscas.ac.cn
Applied to u-boot/next, thanks!
participants (3)
-
Simon Glass -
sunying＠nj.iscas.ac.cn -
Tom Rini