[U-Boot] [PATCH 1/1] imx: imx6ull: correct get_cpu_speed_grade_hz on 696MHz SoCs

Return the correct value when the speed grade is 696MHz. This makes U-Boot to print the correct value at boot:
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)
CPU: Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)
instead of
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)
CPU: Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz) Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- arch/arm/mach-imx/mx6/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c index af31673..7607456 100644 --- a/arch/arm/mach-imx/mx6/soc.c +++ b/arch/arm/mach-imx/mx6/soc.c @@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void) if (val == OCOTP_CFG3_SPEED_528MHZ) return 528000000; else if (val == OCOTP_CFG3_SPEED_696MHZ) - return 69600000; + return 696000000; else return 0; }

On 02/08/2017 12:15, Sébastien Szymanski wrote:
Return the correct value when the speed grade is 696MHz. This makes U-Boot to print the correct value at boot:
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)
CPU: Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)
instead of
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)
CPU: Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz) Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com
arch/arm/mach-imx/mx6/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c index af31673..7607456 100644 --- a/arch/arm/mach-imx/mx6/soc.c +++ b/arch/arm/mach-imx/mx6/soc.c @@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void) if (val == OCOTP_CFG3_SPEED_528MHZ) return 528000000; else if (val == OCOTP_CFG3_SPEED_696MHZ)
return 69600000;
else return 0; }return 696000000;
Reviewed-by: Stefano Babic sbabic@denx.de
Best regards, Stefano Babic

Hi,
On 08/02/2017 12:11 PM, Stefano Babic wrote:
On 02/08/2017 12:15, Sébastien Szymanski wrote:
Return the correct value when the speed grade is 696MHz. This makes U-Boot to print the correct value at boot:
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)
CPU: Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)
instead of
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)
CPU: Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz) Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com
arch/arm/mach-imx/mx6/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c index af31673..7607456 100644 --- a/arch/arm/mach-imx/mx6/soc.c +++ b/arch/arm/mach-imx/mx6/soc.c @@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void) if (val == OCOTP_CFG3_SPEED_528MHZ) return 528000000; else if (val == OCOTP_CFG3_SPEED_696MHZ)
return 69600000;
else return 0; }return 696000000;
Reviewed-by: Stefano Babic sbabic@denx.de
Thanks. However, I've just noticed this is only true for i.MX6UL. i.MX6ULL has different speed grading.
Should I resend my patch and fix the commit log?
Best regards,
Best regards, Stefano Babic

On 02/08/2017 15:09, Sébastien Szymanski wrote:
Hi,
On 08/02/2017 12:11 PM, Stefano Babic wrote:
On 02/08/2017 12:15, Sébastien Szymanski wrote:
Return the correct value when the speed grade is 696MHz. This makes U-Boot to print the correct value at boot:
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)
CPU: Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)
instead of
U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)
CPU: Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz) Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com
arch/arm/mach-imx/mx6/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c index af31673..7607456 100644 --- a/arch/arm/mach-imx/mx6/soc.c +++ b/arch/arm/mach-imx/mx6/soc.c @@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void) if (val == OCOTP_CFG3_SPEED_528MHZ) return 528000000; else if (val == OCOTP_CFG3_SPEED_696MHZ)
return 69600000;
else return 0; }return 696000000;
Reviewed-by: Stefano Babic sbabic@denx.de
Thanks. However, I've just noticed this is only true for i.MX6UL. i.MX6ULL has different speed grading.> Should I resend my patch and fix the commit log?
Yes, thanks for noting thius. I have not yet merged the patch and I appreciate if this is fixed, too. Please send a V2.
Best regards, Stefano Babic
participants (2)
-
Stefano Babic
-
Sébastien Szymanski