[U-Boot] [PATCH 1/1] rockchip: rk3399: spl: implicit declaration back_to_bootrom
Without #include asm/arch-rockchip/bootrom.h we get:
arch/arm/mach-rockchip/rk3399-board-spl.c:162:2: warning: implicit declaration of function ‘back_to_bootrom’ [-Wimplicit-function-declaration]
for CONFIG_ROCKCHIP_BACK_TO_BROM=y
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- arch/arm/mach-rockchip/rk3399-board-spl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-rockchip/rk3399-board-spl.c b/arch/arm/mach-rockchip/rk3399-board-spl.c index d6bf74f7ad..014b8afba0 100644 --- a/arch/arm/mach-rockchip/rk3399-board-spl.c +++ b/arch/arm/mach-rockchip/rk3399-board-spl.c @@ -16,6 +16,7 @@ #include <asm/arch/periph.h> #include <asm/arch/sdram.h> #include <asm/arch/timer.h> +#include <asm/arch-rockchip/bootrom.h> #include <dm/pinctrl.h> #include <power/regulator.h>
Without #include asm/arch-rockchip/bootrom.h we get:
arch/arm/mach-rockchip/rk3399-board-spl.c:162:2: warning: implicit declaration of function ‘back_to_bootrom’ [-Wimplicit-function-declaration]
for CONFIG_ROCKCHIP_BACK_TO_BROM=y
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- v2: rebase to rockchip/master HEAD --- arch/arm/mach-rockchip/rk3399-board-spl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-rockchip/rk3399-board-spl.c b/arch/arm/mach-rockchip/rk3399-board-spl.c index 3406156447..37c48bd1dd 100644 --- a/arch/arm/mach-rockchip/rk3399-board-spl.c +++ b/arch/arm/mach-rockchip/rk3399-board-spl.c @@ -9,6 +9,7 @@ #include <asm/arch/grf_rk3399.h> #include <asm/arch/hardware.h> #include <asm/arch/periph.h> +#include <asm/arch-rockchip/bootrom.h> #include <asm/io.h> #include <debug_uart.h> #include <dm.h>
On 27 Sep 2017, at 21:05, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Without #include asm/arch-rockchip/bootrom.h we get:
arch/arm/mach-rockchip/rk3399-board-spl.c:162:2: warning: implicit declaration of function ‘back_to_bootrom’ [-Wimplicit-function-declaration]
for CONFIG_ROCKCHIP_BACK_TO_BROM=y
We already had the conversion of the rk3399 SPL support to use BOOT_DEVICE_BOOTROM scheduled in https://patchwork.ozlabs.org/patch/812308/
Looks like this got lost somewhere along the way together with a few other changes from around that time. I’ll need to look into what happened there.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
v2: rebase to rockchip/master HEAD
arch/arm/mach-rockchip/rk3399-board-spl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-rockchip/rk3399-board-spl.c b/arch/arm/mach-rockchip/rk3399-board-spl.c index 3406156447..37c48bd1dd 100644 --- a/arch/arm/mach-rockchip/rk3399-board-spl.c +++ b/arch/arm/mach-rockchip/rk3399-board-spl.c @@ -9,6 +9,7 @@ #include <asm/arch/grf_rk3399.h> #include <asm/arch/hardware.h> #include <asm/arch/periph.h> +#include <asm/arch-rockchip/bootrom.h> #include <asm/io.h> #include <debug_uart.h>
#include <dm.h>
2.14.1
participants (2)
-
Dr. Philipp Tomsich -
Heinrich Schuchardt