[U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial
Add support for rockchip rk33 series Soc like rk3368 and rk3399
Signed-off-by: Kever Yang kever.yang@rock-chips.com ---
tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 }, + { "rk33xx", "RK33", 0x20000 }, };
static unsigned char rc4_key[16] = {
Am 14.07.2016 um 05:51 schrieb Kever Yang:
Add support for rockchip rk33 series Soc like rk3368 and rk3399
Signed-off-by: Kever Yang kever.yang@rock-chips.com
tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 },
- { "rk33xx", "RK33", 0x20000 },
Is xx really future-safe or would it be better to have two lines with the exact model names as before?
Cheers, Andreas
};
static unsigned char rc4_key[16] = {
Hi Andreas,
On 07/14/2016 12:26 PM, Andreas Färber wrote:
Am 14.07.2016 um 05:51 schrieb Kever Yang:
Add support for rockchip rk33 series Soc like rk3368 and rk3399
Signed-off-by: Kever Yang kever.yang@rock-chips.com
tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 },
- { "rk33xx", "RK33", 0x20000 },
Is xx really future-safe or would it be better to have two lines with the exact model names as before?
Two information here, one is TAG 'RK33' which used by bootrom, they are the same for rk33 series SoC; another is SPL size which is depend on IRAM size, this is different for different SoC, rk3368 is smaller than rk3399.
I will use rk3399 first, but we may need to optimize the size limit later for the tool, because the image in Rockchip IDB format could be two parts, one like SPL should be run in IRAM, and another one like U-boot can be run in DRAM, the tool only consider the SPL part now.
Thanks, - Kever
Cheers, Andreas
};
static unsigned char rc4_key[16] = {
On 13 July 2016 at 21:51, Kever Yang kever.yang@rock-chips.com wrote:
Add support for rockchip rk33 series Soc like rk3368 and rk3399
Signed-off-by: Kever Yang kever.yang@rock-chips.com
tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 },
{ "rk33xx", "RK33", 0x20000 },};
static unsigned char rc4_key[16] = {
1.9.1
Acked-by: Simon Glass sjg@chromium.org
On 14 July 2016 at 21:20, Simon Glass sjg@chromium.org wrote:
On 13 July 2016 at 21:51, Kever Yang kever.yang@rock-chips.com wrote:
Add support for rockchip rk33 series Soc like rk3368 and rk3399
Signed-off-by: Kever Yang kever.yang@rock-chips.com
tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 },
{ "rk33xx", "RK33", 0x20000 },};
static unsigned char rc4_key[16] = {
1.9.1
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-rockchip, thanks!
Simon,
Am 15.07.2016 um 05:56 schrieb Simon Glass:
On 14 July 2016 at 21:20, Simon Glass sjg@chromium.org wrote:
On 13 July 2016 at 21:51, Kever Yang kever.yang@rock-chips.com wrote:
Add support for rockchip rk33 series Soc like rk3368 and rk3399
Signed-off-by: Kever Yang kever.yang@rock-chips.com
tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 },
{ "rk33xx", "RK33", 0x20000 },};
static unsigned char rc4_key[16] = {
1.9.1
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-rockchip, thanks!
Didn't he just reply that it should be 3399 instead of 33xx because 3368 needs a different third column?
Andreas
Hi Andreas,
On 16 July 2016 at 10:04, Andreas Färber afaerber@suse.de wrote:
Simon,
Am 15.07.2016 um 05:56 schrieb Simon Glass:
On 14 July 2016 at 21:20, Simon Glass sjg@chromium.org wrote:
On 13 July 2016 at 21:51, Kever Yang kever.yang@rock-chips.com wrote:
Add support for rockchip rk33 series Soc like rk3368 and rk3399
Signed-off-by: Kever Yang kever.yang@rock-chips.com
tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 },
{ "rk33xx", "RK33", 0x20000 },};
static unsigned char rc4_key[16] = {
1.9.1
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-rockchip, thanks!
Didn't he just reply that it should be 3399 instead of 33xx because 3368 needs a different third column?
Ah yes. We don't actually have 3368, but it would be good to fix the string now. Kever can you please send a patch?
Regards, Simon
participants (3)
-
Andreas Färber -
Kever Yang -
Simon Glass