[U-Boot-Users] [PATCH ARM/IXP465 1/3] Add support for the ixp465 processor
In message 4815AEC6.8060704@gandalf.sssup.it you wrote:
This patch add basic support to the ixp465 cpu.
...
diff --git a/cpu/ixp/start.S b/cpu/ixp/start.S index 757cfaa..af718b0 100644 --- a/cpu/ixp/start.S +++ b/cpu/ixp/start.S @@ -29,7 +29,8 @@
#include <config.h> #include <version.h> -#include <asm/arch/ixp425.h>
+#include <asm/arch/hardware.h>
#define MMU_Control_M 0x001 /* Enable MMU */ #define MMU_Control_A 0x002 /* Enable address alignment faults */ @@ -158,6 +159,16 @@ reset: ldr r2, =IXP425_EXP_CS0
--------------------^^^^^^^^^^^^^^^^
Seems there is IXP425 specific stuff here. Please verify that this is correct. If it is correct, then probably the name should be changed.
+#ifdef CONFIG_IXP465
...
+#ifdef CONFIG_IXP425
...
+#ifdef CONFIG_IXP465
...
+#ifdef CONFIG_IXP465
...
+#else
...
+#ifdef CONFIG_IXP465
...
+#ifdef CONFIG_IXP465
...
+#else
That's a pretty mess of #ifdef's.
Maybe we should split this into separate source files?
Best regards,
Wolfgang Denk
Hi, thanks for your comment.
Wolfgang Denk wrote:
In message 4815AEC6.8060704@gandalf.sssup.it you wrote:
This patch add basic support to the ixp465 cpu.
...
diff --git a/cpu/ixp/start.S b/cpu/ixp/start.S index 757cfaa..af718b0 100644 --- a/cpu/ixp/start.S +++ b/cpu/ixp/start.S @@ -29,7 +29,8 @@
#include <config.h> #include <version.h> -#include <asm/arch/ixp425.h>
+#include <asm/arch/hardware.h>
#define MMU_Control_M 0x001 /* Enable MMU */ #define MMU_Control_A 0x002 /* Enable address alignment faults */ @@ -158,6 +159,16 @@ reset: ldr r2, =IXP425_EXP_CS0
--------------------^^^^^^^^^^^^^^^^
Seems there is IXP425 specific stuff here. Please verify that this is correct. If it is correct, then probably the name should be changed.
I think about to merge the two includes file. Maybe I take it from linux and use that one. There a lot of information shared. In linux the name is for example IXP4XX_ ... What do you think about it?
+#ifdef CONFIG_IXP465
...
+#ifdef CONFIG_IXP465
...
+#else
That's a pretty mess of #ifdef's.
Maybe we should split this into separate source files?
I try to write just one ifdef, and duplicate a little bit the code. Is good for you?
Best regards,
Wolfgang Denk
Michael
participants (2)
-
michael -
Wolfgang Denk