[PATCH] firmware: xilinx: Use explicit values for all enum values
Based on discussion at https://lore.kernel.org/r/20200318125003.GA2727094@kroah.com we got recommendation to use explicit values for all enum values. The patch is following this recommendation.
Signed-off-by: Michal Simek michal.simek@xilinx.com Link: https://lore.kernel.org/r/daeb67ded45d8a8f6a96717d1fb9c84439dd2ae8.161236162... ---
include/zynqmp_firmware.h | 93 +++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 44 deletions(-)
diff --git a/include/zynqmp_firmware.h b/include/zynqmp_firmware.h index f6f82bf8828e..669af6765ce9 100644 --- a/include/zynqmp_firmware.h +++ b/include/zynqmp_firmware.h @@ -10,54 +10,59 @@
enum pm_api_id { PM_GET_API_VERSION = 1, - PM_SET_CONFIGURATION, - PM_GET_NODE_STATUS, - PM_GET_OPERATING_CHARACTERISTIC, - PM_REGISTER_NOTIFIER, - PM_REQUEST_SUSPEND, - PM_SELF_SUSPEND, - PM_FORCE_POWERDOWN, - PM_ABORT_SUSPEND, - PM_REQUEST_WAKEUP, - PM_SET_WAKEUP_SOURCE, - PM_SYSTEM_SHUTDOWN, - PM_REQUEST_NODE, - PM_RELEASE_NODE, - PM_SET_REQUIREMENT, - PM_SET_MAX_LATENCY, - PM_RESET_ASSERT, - PM_RESET_GET_STATUS, - PM_MMIO_WRITE, - PM_MMIO_READ, - PM_PM_INIT_FINALIZE, - PM_FPGA_LOAD, - PM_FPGA_GET_STATUS, - PM_GET_CHIPID, + PM_SET_CONFIGURATION = 2, + PM_GET_NODE_STATUS = 3, + PM_GET_OPERATING_CHARACTERISTIC = 4, + PM_REGISTER_NOTIFIER = 5, + /* API for suspending */ + PM_REQUEST_SUSPEND = 6, + PM_SELF_SUSPEND = 7, + PM_FORCE_POWERDOWN = 8, + PM_ABORT_SUSPEND = 9, + PM_REQUEST_WAKEUP = 10, + PM_SET_WAKEUP_SOURCE = 11, + PM_SYSTEM_SHUTDOWN = 12, + PM_REQUEST_NODE = 13, + PM_RELEASE_NODE = 14, + PM_SET_REQUIREMENT = 15, + PM_SET_MAX_LATENCY = 16, + /* Direct control API functions: */ + PM_RESET_ASSERT = 17, + PM_RESET_GET_STATUS = 18, + PM_MMIO_WRITE = 19, + PM_MMIO_READ = 20, + PM_PM_INIT_FINALIZE = 21, + PM_FPGA_LOAD = 22, + PM_FPGA_GET_STATUS = 23, + PM_GET_CHIPID = 24, + /* ID 25 is been used by U-boot to process secure boot images */ + /* Secure library generic API functions */ PM_SECURE_SHA = 26, - PM_SECURE_RSA, - PM_PINCTRL_REQUEST, - PM_PINCTRL_RELEASE, - PM_PINCTRL_GET_FUNCTION, - PM_PINCTRL_SET_FUNCTION, - PM_PINCTRL_CONFIG_PARAM_GET, - PM_PINCTRL_CONFIG_PARAM_SET, - PM_IOCTL, - PM_QUERY_DATA, - PM_CLOCK_ENABLE, - PM_CLOCK_DISABLE, - PM_CLOCK_GETSTATE, - PM_CLOCK_SETDIVIDER, - PM_CLOCK_GETDIVIDER, - PM_CLOCK_SETRATE, - PM_CLOCK_GETRATE, - PM_CLOCK_SETPARENT, - PM_CLOCK_GETPARENT, - PM_SECURE_IMAGE, + PM_SECURE_RSA = 27, + PM_PINCTRL_REQUEST = 28, + PM_PINCTRL_RELEASE = 29, + PM_PINCTRL_GET_FUNCTION = 30, + PM_PINCTRL_SET_FUNCTION = 31, + PM_PINCTRL_CONFIG_PARAM_GET = 32, + PM_PINCTRL_CONFIG_PARAM_SET = 33, + PM_IOCTL = 34, + PM_QUERY_DATA = 35, + PM_CLOCK_ENABLE = 36, + PM_CLOCK_DISABLE = 37, + PM_CLOCK_GETSTATE = 38, + PM_CLOCK_SETDIVIDER = 39, + PM_CLOCK_GETDIVIDER = 40, + PM_CLOCK_SETRATE = 41, + PM_CLOCK_GETRATE = 42, + PM_CLOCK_SETPARENT = 43, + PM_CLOCK_GETPARENT = 44, + PM_SECURE_IMAGE = 45, PM_FPGA_READ = 46, - PM_SECURE_AES, + PM_SECURE_AES = 47, PM_CLOCK_PLL_GETPARAM = 49, + /* PM_REGISTER_ACCESS API */ PM_REGISTER_ACCESS = 52, - PM_EFUSE_ACCESS, + PM_EFUSE_ACCESS = 53, PM_FEATURE_CHECK = 63, PM_API_MAX, };
pá 30. 7. 2021 v 11:44 odesílatel Michal Simek michal.simek@xilinx.com napsal:
Based on discussion at https://lore.kernel.org/r/20200318125003.GA2727094@kroah.com we got recommendation to use explicit values for all enum values. The patch is following this recommendation.
Signed-off-by: Michal Simek michal.simek@xilinx.com Link: https://lore.kernel.org/r/daeb67ded45d8a8f6a96717d1fb9c84439dd2ae8.161236162...
include/zynqmp_firmware.h | 93 +++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 44 deletions(-)
diff --git a/include/zynqmp_firmware.h b/include/zynqmp_firmware.h index f6f82bf8828e..669af6765ce9 100644 --- a/include/zynqmp_firmware.h +++ b/include/zynqmp_firmware.h @@ -10,54 +10,59 @@
enum pm_api_id { PM_GET_API_VERSION = 1,
PM_SET_CONFIGURATION,PM_GET_NODE_STATUS,PM_GET_OPERATING_CHARACTERISTIC,PM_REGISTER_NOTIFIER,PM_REQUEST_SUSPEND,PM_SELF_SUSPEND,PM_FORCE_POWERDOWN,PM_ABORT_SUSPEND,PM_REQUEST_WAKEUP,PM_SET_WAKEUP_SOURCE,PM_SYSTEM_SHUTDOWN,PM_REQUEST_NODE,PM_RELEASE_NODE,PM_SET_REQUIREMENT,PM_SET_MAX_LATENCY,PM_RESET_ASSERT,PM_RESET_GET_STATUS,PM_MMIO_WRITE,PM_MMIO_READ,PM_PM_INIT_FINALIZE,PM_FPGA_LOAD,PM_FPGA_GET_STATUS,PM_GET_CHIPID,
PM_SET_CONFIGURATION = 2,PM_GET_NODE_STATUS = 3,PM_GET_OPERATING_CHARACTERISTIC = 4,PM_REGISTER_NOTIFIER = 5,/* API for suspending */PM_REQUEST_SUSPEND = 6,PM_SELF_SUSPEND = 7,PM_FORCE_POWERDOWN = 8,PM_ABORT_SUSPEND = 9,PM_REQUEST_WAKEUP = 10,PM_SET_WAKEUP_SOURCE = 11,PM_SYSTEM_SHUTDOWN = 12,PM_REQUEST_NODE = 13,PM_RELEASE_NODE = 14,PM_SET_REQUIREMENT = 15,PM_SET_MAX_LATENCY = 16,/* Direct control API functions: */PM_RESET_ASSERT = 17,PM_RESET_GET_STATUS = 18,PM_MMIO_WRITE = 19,PM_MMIO_READ = 20,PM_PM_INIT_FINALIZE = 21,PM_FPGA_LOAD = 22,PM_FPGA_GET_STATUS = 23,PM_GET_CHIPID = 24,/* ID 25 is been used by U-boot to process secure boot images *//* Secure library generic API functions */ PM_SECURE_SHA = 26,
PM_SECURE_RSA,PM_PINCTRL_REQUEST,PM_PINCTRL_RELEASE,PM_PINCTRL_GET_FUNCTION,PM_PINCTRL_SET_FUNCTION,PM_PINCTRL_CONFIG_PARAM_GET,PM_PINCTRL_CONFIG_PARAM_SET,PM_IOCTL,PM_QUERY_DATA,PM_CLOCK_ENABLE,PM_CLOCK_DISABLE,PM_CLOCK_GETSTATE,PM_CLOCK_SETDIVIDER,PM_CLOCK_GETDIVIDER,PM_CLOCK_SETRATE,PM_CLOCK_GETRATE,PM_CLOCK_SETPARENT,PM_CLOCK_GETPARENT,PM_SECURE_IMAGE,
PM_SECURE_RSA = 27,PM_PINCTRL_REQUEST = 28,PM_PINCTRL_RELEASE = 29,PM_PINCTRL_GET_FUNCTION = 30,PM_PINCTRL_SET_FUNCTION = 31,PM_PINCTRL_CONFIG_PARAM_GET = 32,PM_PINCTRL_CONFIG_PARAM_SET = 33,PM_IOCTL = 34,PM_QUERY_DATA = 35,PM_CLOCK_ENABLE = 36,PM_CLOCK_DISABLE = 37,PM_CLOCK_GETSTATE = 38,PM_CLOCK_SETDIVIDER = 39,PM_CLOCK_GETDIVIDER = 40,PM_CLOCK_SETRATE = 41,PM_CLOCK_GETRATE = 42,PM_CLOCK_SETPARENT = 43,PM_CLOCK_GETPARENT = 44,PM_SECURE_IMAGE = 45, PM_FPGA_READ = 46,
PM_SECURE_AES,
PM_SECURE_AES = 47, PM_CLOCK_PLL_GETPARAM = 49,/* PM_REGISTER_ACCESS API */ PM_REGISTER_ACCESS = 52,
PM_EFUSE_ACCESS,
PM_EFUSE_ACCESS = 53, PM_FEATURE_CHECK = 63, PM_API_MAX,};
2.32.0
Applied. M
participants (2)
-
Michal Simek -
Michal Simek