Re: [U-Boot] [PATCH v7 1/5] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform
Hi Stefan,
From: Stefan Roese [mailto:sr@denx.de]
On 30.09.2013 16:13, Pekon Gupta wrote: BCH8_ECC scheme implemented in omap_gpmc.c driver has following
favours
+-----------------------------------+-----------------+-----------------+ |ECC Scheme | ECC Calculation | Error Detection | +-----------------------------------+-----------------+-----------------+ |OMAP_ECC_BCH8_CODE_HW |GPMC |ELM H/W engine | |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |GPMC |S/W BCH
library |
+-----------------------------------+-----------------+-----------------+
Current implementation limits the BCH8_CODE_HW only for AM33xx
device family.
(using CONFIG_AM33XX). However, other SoC families (like TI81xx) also
have
ELM hardware module, and can support ECC error detection using ELM.
This patch
- removes CONFIG_AM33xx Thus this driver can be reused by all devices having ELM h/w engine.
Do you have an overview, which TI devices actually have this ELM h/w engine integrated? Especially if its integrated in the OMAP3530 SoC? I'm currently scanning the users manual and can't find any reference to this IP block.
As per my knowledge, omap device families from omap44xx onwards have ELM hardware. Example: omap44xx, omap54xx. But earlier omap devices like omap2xxx, omap34xx and omap35xx do not have ELM engine.
So, If you are using omap34xx, omap35xx devices then please select OMAP_ECC_BCH8_CODE_HW_DETECTION_SW ecc-scheme. In this ecc-scheme, ECC error correction would require lib/bch.c which needs to be enabled via CONFIG_BCH.
with regards, pekon
Hi Stefan,
From: Stefan Roese [mailto:sr@denx.de]
On 30.09.2013 16:13, Pekon Gupta wrote: BCH8_ECC scheme implemented in omap_gpmc.c driver has following
favours
+-----------------------------------+-----------------+-----------------+ |ECC Scheme | ECC Calculation | Error Detection | +-----------------------------------+-----------------+-----------------+ |OMAP_ECC_BCH8_CODE_HW |GPMC |ELM H/W engine | |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |GPMC |S/W BCH
library |
+-----------------------------------+-----------------+-----------------+
Current implementation limits the BCH8_CODE_HW only for AM33xx
device family.
(using CONFIG_AM33XX). However, other SoC families (like TI81xx) also
have
ELM hardware module, and can support ECC error detection using ELM.
This patch
- removes CONFIG_AM33xx Thus this driver can be reused by all devices having ELM h/w engine.
Do you have an overview, which TI devices actually have this ELM h/w engine integrated? Especially if its integrated in the OMAP3530 SoC? I'm currently scanning the users manual and can't find any reference to this IP block.
Incase you are working on a x16 device on omap35xx, then you might like to look at following patch set also. This allows: - SPL boot: device-width can be set via CONFIG_SYS_NAND_DEVICE_WIDTH - U-BOOT: device-width is auto-detected via reading on-chip ONFI params.
http://lists.denx.de/pipermail/u-boot/2013-September/163878.html
with regards, pekon
participants (1)
-
Gupta, Pekon