[U-Boot] [PATCH] chiliboard config: use CONFIG_DEFAULT_FDT_FILE as env variable
Remove hardcoded ftd file name from environment variables. Use CONFIG_DEFAULT_FDT_FILE macro instead.
--- include/configs/chiliboard.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/chiliboard.h b/include/configs/chiliboard.h index b7887d90d4..153789e6be 100644 --- a/include/configs/chiliboard.h +++ b/include/configs/chiliboard.h @@ -45,7 +45,7 @@ "boot_fdt=try\0" \ "console=ttyO0,115200n8\0" \ "image=zImage\0" \ - "fdt_file=am335x-chiliboard.dtb\0" \ + "fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \ "ip_dyn=yes\0" \ "optargs=\0" \ "loadbootscript=" \
Hi,
Please add subsystem/board maintainers to CC list when sending patches. This should give you faster response. You can use scripts/get_maintainer.pl to get list of maintainers / previous submitters.
On 17.10.2017 11:45, Michal Oleszczyk wrote:
Remove hardcoded ftd file name from environment variables. Use CONFIG_DEFAULT_FDT_FILE macro instead.
There is no Signed-off-by line. Please verify your patches with scripts/checkpatch.pl before submitting.
include/configs/chiliboard.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/chiliboard.h b/include/configs/chiliboard.h index b7887d90d4..153789e6be 100644 --- a/include/configs/chiliboard.h +++ b/include/configs/chiliboard.h @@ -45,7 +45,7 @@ "boot_fdt=try\0" \ "console=ttyO0,115200n8\0" \ "image=zImage\0" \
- "fdt_file=am335x-chiliboard.dtb\0" \
- "fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \ "ip_dyn=yes\0" \ "optargs=\0" \ "loadbootscript=" \
After applying patch u-boot does not boot anymore. You need to set CONFIG_DEFAULT_FDT_FILE in configs/chiliboard_defconfig first. Below is boot log:
------------------------------------------------------------ U-Boot SPL 2017.01 (Oct 13 2017 - 17:09:20) Trying to boot from MMC1 reading u-boot.img reading u-boot.img
U-Boot 2017.11-rc2-00001-g5c398b70cb (Oct 17 2017 - 12:44:59 +0200)
CPU : AM335X-GP rev 2.1 I2C: ready DRAM: 256 MiB NAND: 256 MiB MMC: OMAP SD/MMC: 0, OMAP SD/MMC: 1 *** Warning - bad CRC, using default environment
<ethaddr> not set. Validating first E-fuse MAC Net: cpsw Hit any key to stop autoboot: 0 switch to partitions #0, OK mmc0 is current device SD/MMC found on device 0 reading /zImage 5465752 bytes read in 346 ms (15.1 MiB/s) ** Unable to read file / **
Starting kernel ... -------------------------------------------------------------
participants (2)
-
Marcin Niestroj -
Michal Oleszczyk