[U-Boot] [PATCH] ddr: altera: sequencer: add RW_MGR_MEM_NUMBER_OF_RANKS

From: Dinh Nguyen dinguyen@opensource.altera.com
Fix build error for socfpga_cyclone5_defconfig:
board/altera/socfpga/wrap_sdram_config.c:245:26: error: ‘RW_MGR_MEM_NUMBER_OF_RANKS’ undeclared here (not in a function) make[2]: *** [spl/board/altera/socfpga/wrap_sdram_config.o] Error 1
Signed-off-by: Dinh Nguyen dinguyen@opensource.altera.com --- Hi Marek,
This patch is based on your 02-ddr-part3 branch. It is also applicable to the wip/boards branch as well.
Thanks, Dinh --- board/altera/socfpga/qts/sequencer_defines.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/board/altera/socfpga/qts/sequencer_defines.h b/board/altera/socfpga/qts/sequencer_defines.h index 32f13ac..bfe5b27 100644 --- a/board/altera/socfpga/qts/sequencer_defines.h +++ b/board/altera/socfpga/qts/sequencer_defines.h @@ -103,6 +103,7 @@ #define RW_MGR_MEM_IF_READ_DQS_WIDTH 5 #define RW_MGR_MEM_IF_WRITE_DQS_WIDTH 5 #define RW_MGR_MEM_NUMBER_OF_CS_PER_DIMM 1 +#define RW_MGR_MEM_NUMBER_OF_RANKS 1 #define RW_MGR_MEM_ODT_WIDTH 1 #define RW_MGR_MEM_VIRTUAL_GROUPS_PER_READ_DQS 1 #define RW_MGR_MEM_VIRTUAL_GROUPS_PER_WRITE_DQS 1

On Wednesday, August 05, 2015 at 05:12:32 AM, dinguyen@opensource.altera.com wrote:
From: Dinh Nguyen dinguyen@opensource.altera.com
Fix build error for socfpga_cyclone5_defconfig:
board/altera/socfpga/wrap_sdram_config.c:245:26: error: ‘RW_MGR_MEM_NUMBER_OF_RANKS’ undeclared here (not in a function) make[2]: *** [spl/board/altera/socfpga/wrap_sdram_config.o] Error 1
Signed-off-by: Dinh Nguyen dinguyen@opensource.altera.com
Hi Marek,
This patch is based on your 02-ddr-part3 branch. It is also applicable to the wip/boards branch as well.
Hi,
Ouch, thanks for spotting this!
Acked-by: Marek Vasut marex@denx.de
btw. did you have time to skim through [PATCH 00/28] socfpga: sdram.c cleanups please ? I'd like to apply that to master, put on the sequencer cleanups and this patch and then submit a PR :)
Best regards, Marek Vasut

On 8/5/15 3:57 AM, Marek Vasut wrote:
btw. did you have time to skim through [PATCH 00/28] socfpga: sdram.c cleanups please ? I'd like to apply that to master, put on the sequencer cleanups and this patch and then submit a PR :)
Oh, I didn't see this series come in. You've been so quiet, :). I'll look for it.
Thanks, Dinh

On Wednesday, August 05, 2015 at 03:22:04 PM, Dinh Nguyen wrote:
On 8/5/15 3:57 AM, Marek Vasut wrote:
btw. did you have time to skim through [PATCH 00/28] socfpga: sdram.c cleanups please ? I'd like to apply that to master, put on the sequencer cleanups and this patch and then submit a PR :)
Oh, I didn't see this series come in. You've been so quiet, :). I'll look for it.
Maybe the spam filter in Altera blocked me for a while there :-) Thanks!
Best regards, Marek Vasut

On Wednesday, August 05, 2015 at 05:12:32 AM, dinguyen@opensource.altera.com wrote:
From: Dinh Nguyen dinguyen@opensource.altera.com
Fix build error for socfpga_cyclone5_defconfig:
board/altera/socfpga/wrap_sdram_config.c:245:26: error: ‘RW_MGR_MEM_NUMBER_OF_RANKS’ undeclared here (not in a function) make[2]: *** [spl/board/altera/socfpga/wrap_sdram_config.o] Error 1
Signed-off-by: Dinh Nguyen dinguyen@opensource.altera.com
Applied, thanks!
Best regards, Marek Vasut
participants (3)
-
dinguyen@opensource.altera.com
-
Dinh Nguyen
-
Marek Vasut