[U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver
Move the c-preprocessor conditional check for compiling the ks8695eth driver code to after including the headers. Otherwise it can never be compiled in.
Index: drivers/ks8695eth.c =================================================================== RCS file: /cvsroot/u-boot/u-boot/drivers/ks8695eth.c,v retrieving revision 1.2 diff -u -r1.2 ks8695eth.c --- drivers/ks8695eth.c 23 May 2005 10:49:51 -0000 1.2 +++ drivers/ks8695eth.c 3 Jun 2005 14:13:54 -0000 @@ -18,8 +18,6 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
-#ifdef CONFIG_DRIVER_KS8695ETH - /****************************************************************************/
#include <common.h> @@ -28,6 +26,7 @@ #include <asm/io.h> #include <asm/arch/platform.h>
+#ifdef CONFIG_DRIVER_KS8695ETH /****************************************************************************/
/*
In message 42A06968.3050706@moreton.com.au you wrote:
Move the c-preprocessor conditional check for compiling the ks8695eth driver code to after including the headers. Otherwise it can never be compiled in.
Applied. But please provide a proper CHANGELOG entry next time!
Best regards,
Wolfgang Denk
Hi Wolfgang Denk,
This commit breaks compile of boards without <asm/arch/platform.h>.
Example:
$ make Sandpoint8240_config; make
Relevant files
$ grep -R asm/arch/platform.h * board/cm41xx/cm41xx.c:#include <asm/arch/platform.h> board/cm4008/cm4008.c:#include <asm/arch/platform.h> cpu/arm920t/ks8695/interrupts.c:#include <asm/arch/platform.h> cpu/arm920t/ks8695/lowlevel_init.S:#include <asm/arch/platform.h> cpu/arm920t/ks8695/serial.c:#include <asm/arch/platform.h> drivers/ks8695eth.c:#include <asm/arch/platform.h> grep: include/asm/arch: No such file or directory grep: include/asm-ppc/arch: No such file or directory
$ find . -name platform.h ./include/asm-microblaze/platform.h ./include/asm-arm/arch-ks8695/platform.h
On Sun, 12 Mar 2006 01:40:36 +0100, Wolfgang Denk wd@denx.de wrote:
In message 42A06968.3050706@moreton.com.au you wrote:
Move the c-preprocessor conditional check for compiling the ks8695eth driver code to after including the headers. Otherwise it can never be compiled in.
Applied. But please provide a proper CHANGELOG entry next time!
Best regards,
Wolfgang Denk
-- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de In an infinite universe all things are possible, including the possi- bility that the universe does not exist. - Terry Pratchett, _The Dark Side of the Sun_
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%1... _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
In message 20060313005521.8B6C.LARK@linux.net.cn you wrote:
This commit breaks compile of boards without <asm/arch/platform.h>.
Thanks for pointing out. Fixed.
Best regards,
Wolfgang Denk
participants (3)
-
Greg Ungerer -
Wang Jian -
Wolfgang Denk