[U-Boot-Users] MPC8266ADS patch
Here is a patch to get a 8266 booting with the default board configuration. Notes: 1. The patch to examples/Makefile should be included as a comment. People with MontaVista 2.0 (possibly other versions too) need this change. 2. This assumes that you have the small flash module. (should work fine with larger modules) 3. I followed some of the messages regarding booting the 8266. None of them appeared to address the address differences for the BCSR and PCI interrupt controller. (include/configs/MPC8266ADS.h)
Index: board/mpc8266ads/config.mk ================================================================== RCS file: /cvsroot/u-boot/u-boot/board/mpc8266ads/config.mk,v retrieving revision 1.2 diff -r1.2 config.mk 30c30 < TEXT_BASE = 0xfe000000 --- > TEXT_BASE = 0xfff00000 Index: examples/Makefile ================================================================== RCS file: /cvsroot/u-boot/u-boot/examples/Makefile,v retrieving revision 1.7 diff -r1.7 Makefile 81c81 < $(OBJCOPY) -O binary $< $@ 2>/dev/null --- > $(OBJCOPY) -O ppcboot $< $@ 2>/dev/null Index: include/configs/MPC8266ADS.h ================================================================== RCS file: /cvsroot/u-boot/u-boot/include/configs/MPC8266ADS.h,v retrieving revision 1.4 diff -r1.4 MPC8266ADS.h 236,237c236,237 < #define CFG_FLASH_BASE 0xFE000000 < #define FLASH_BASE 0xFE000000 --- > #define CFG_FLASH_BASE 0xFF800000 > #define FLASH_BASE 0xFF800000 252,253c252,253 < #define CFG_BCSR 0xF8000000 < #define CFG_PCI_INT 0xF8200000 /* PCI interrupt controller */ --- > #define CFG_BCSR 0x04500000 > #define CFG_PCI_INT 0x04730000 /* PCI interrupt controller */
Dear Aleen,
in message 5.2.1.1.2.20030910173720.0275bce0@192.168.1.10 you wrote:
Here is a patch to get a 8266 booting with the default board configuration.
This is not a patch, this is crap.
Please see the README for instructions how to create a patch. The use of CONTEXT or (better) UNIFIED diffs is mandatory. Plain diffs as yours are useless.
Also make sure that your mailer does not reformat the patch. If necessary, use an attachment instead of inline text.
Notes:
- The patch to examples/Makefile should be included as a comment. People
with MontaVista 2.0 (possibly other versions too) need this change.
...
< $(OBJCOPY) -O binary $< $@ 2>/dev/null
$(OBJCOPY) -O ppcboot $< $@ 2>/dev/null
Please explain why. Does the MontaVista version of the binutils doe not understand "binary" output format any longer?
- This assumes that you have the small flash module. (should work fine
with larger modules) 3. I followed some of the messages regarding booting the 8266. None of them appeared to address the address differences for the BCSR and PCI interrupt controller. (include/configs/MPC8266ADS.h)
Index: board/mpc8266ads/config.mk
RCS file: /cvsroot/u-boot/u-boot/board/mpc8266ads/config.mk,v retrieving revision 1.2 diff -r1.2 config.mk 30c30
< TEXT_BASE = 0xfe000000
TEXT_BASE = 0xfff00000
Please explain why you think this is necessary.
diff -r1.4 MPC8266ADS.h 236,237c236,237 < #define CFG_FLASH_BASE 0xFE000000
< #define FLASH_BASE 0xFE000000
#define CFG_FLASH_BASE 0xFF800000 #define FLASH_BASE 0xFF800000
252,253c252,253 < #define CFG_BCSR 0xF8000000 < #define CFG_PCI_INT 0xF8200000 /* PCI interrupt controller
*/
#define CFG_BCSR 0x04500000 #define CFG_PCI_INT 0x04730000 /* PCI interrupt
controller */
Please explain why you think this is necessary.
Actually I think it is a bug to map the BCSR at a low address like 0x04500000. Are you really, really sure that this will work with Linux?
Patch rejected.
Wolfgang Denk
participants (2)
-
Curtis, Allen -
Wolfgang Denk