Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
Hello Jens,
one comment to your patch:
Jens Gehrlein wrote:
Signed-off-by: Jens Gehrlein sew_s@tqs.de
Fixed two bugs: a) added NFS mount option "rw" to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that.
[...]
+/*******************************************************************************
- Environment
- ******************************************************************************/
+#define CONFIG_BOOTDELAY 4
+/* Default values */ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR 172.20.5.100 +#define CONFIG_SERVERIP 172.20.5.121
Please delete this block. We do not accept such settings in default config files.
bye, Heiko
Hi Heiko,
Heiko Schocher schrieb:
Hello Jens,
one comment to your patch:
Jens Gehrlein wrote:
Signed-off-by: Jens Gehrlein sew_s@tqs.de
Fixed two bugs: a) added NFS mount option "rw" to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that.
[...]
+/*******************************************************************************
- Environment
- ******************************************************************************/
+#define CONFIG_BOOTDELAY 4
+/* Default values */ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR 172.20.5.100 +#define CONFIG_SERVERIP 172.20.5.121
Please delete this block. We do not accept such settings in default config files.
To understand you properly: do you mean the defines for netmask, ipaddr and serverip, i.e. bootdelay and headerline are okay? I ask, because you quoted the upper lines, too.
Kind regards, Jens
Hello Jens,
Jens Gehrlein wrote:
Heiko Schocher schrieb:
Hello Jens,
one comment to your patch:
Jens Gehrlein wrote:
Signed-off-by: Jens Gehrlein sew_s@tqs.de
Fixed two bugs: a) added NFS mount option "rw" to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that.
[...]
+/*******************************************************************************
- Environment
******************************************************************************/
+#define CONFIG_BOOTDELAY 4
+/* Default values */ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR 172.20.5.100 +#define CONFIG_SERVERIP 172.20.5.121
Please delete this block. We do not accept such settings in default config files.
To understand you properly: do you mean the defines for netmask, ipaddr and serverip, i.e. bootdelay and headerline are okay? I ask, because you quoted the upper lines, too.
Yes, I only meant netmask, ipaddr and serverip.
bye Heiko
participants (2)
-
Heiko Schocher -
Jens Gehrlein