[U-Boot] [PATCH 0/2] at91: Fixes the crippled console output on PortuxG20.
In order to use the serial interface on the PortuxG20 we need to enable the level converter first by setting the PC9 pin to high. The level converter needs some time to settle so we have to use the mdelay() function to wait for some time. Unfortunately we have no timers available at board_early_init_f() so we enable the serial output early within board_postclk_init().
Unfortunately the board_postclk_init() function was not called in the init_sequence of arch/arm/lib/board.c so the first patch will added it there.
--- Markus Hubig (2): arm: Adds board_postclk_init to the init_sequence. Fixes the crippled console output on PortuxG20.
arch/arm/lib/board.c | 3 +++ board/taskit/stamp9g20/stamp9g20.c | 21 +++++++++++++++++---- include/configs/stamp9g20.h | 1 + 3 files changed, 21 insertions(+), 4 deletions(-)
The board_postclk_init() function can be used to perform operations that requires a working timer early within the U-Boot init_sequence.
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Albert ARIBAUD albert.u.boot@aribaud.net --- arch/arm/lib/board.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index f1951e8..109a1ac 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -241,6 +241,9 @@ init_fnc_t *init_sequence[] = { fdtdec_check_fdt, #endif timer_init, /* initialize timer */ +#ifdef CONFIG_BOARD_POSTCLK_INIT + board_postclk_init, +#endif #ifdef CONFIG_FSL_ESDHC get_clocks, #endif
Dear Albert Aribaud,
On 16.08.12 20:22, Markus Hubig wrote:
The board_postclk_init() function can be used to perform operations that requires a working timer early within the U-Boot init_sequence.
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Albert ARIBAUD albert.u.boot@aribaud.net
arch/arm/lib/board.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index f1951e8..109a1ac 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -241,6 +241,9 @@ init_fnc_t *init_sequence[] = { fdtdec_check_fdt, #endif timer_init, /* initialize timer */ +#ifdef CONFIG_BOARD_POSTCLK_INIT
- board_postclk_init,
+#endif #ifdef CONFIG_FSL_ESDHC get_clocks, #endif
how do you think about this suggestion? Will you accept it? Should I apply both patches to u-boot-atmel?
Best regards
Andreas Bießmann
Hi Andreas,
On Tue, 04 Sep 2012 21:17:58 +0200, Andreas Bießmann andreas.devel@googlemail.com wrote:
Dear Albert Aribaud,
On 16.08.12 20:22, Markus Hubig wrote:
The board_postclk_init() function can be used to perform operations that requires a working timer early within the U-Boot init_sequence.
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Albert ARIBAUD albert.u.boot@aribaud.net
arch/arm/lib/board.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index f1951e8..109a1ac 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -241,6 +241,9 @@ init_fnc_t *init_sequence[] = { fdtdec_check_fdt, #endif timer_init, /* initialize timer */ +#ifdef CONFIG_BOARD_POSTCLK_INIT
- board_postclk_init,
+#endif #ifdef CONFIG_FSL_ESDHC get_clocks, #endif
how do you think about this suggestion? Will you accept it? Should I apply both patches to u-boot-atmel?
From what I see, this converges with what's been in PPC for a long time... I'm ok with the series going into atmel.
Best regards
Andreas Bießmann
Amicalement,
Hi Albert,
On 04.09.12 21:34, Albert ARIBAUD wrote:
Hi Andreas,
On Tue, 04 Sep 2012 21:17:58 +0200, Andreas Bießmann andreas.devel@googlemail.com wrote:
Dear Albert Aribaud,
On 16.08.12 20:22, Markus Hubig wrote:
The board_postclk_init() function can be used to perform operations that requires a working timer early within the U-Boot init_sequence.
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Albert ARIBAUD albert.u.boot@aribaud.net
arch/arm/lib/board.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index f1951e8..109a1ac 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -241,6 +241,9 @@ init_fnc_t *init_sequence[] = { fdtdec_check_fdt, #endif timer_init, /* initialize timer */ +#ifdef CONFIG_BOARD_POSTCLK_INIT
- board_postclk_init,
+#endif #ifdef CONFIG_FSL_ESDHC get_clocks, #endif
how do you think about this suggestion? Will you accept it? Should I apply both patches to u-boot-atmel?
From what I see, this converges with what's been in PPC for a long time... I'm ok with the series going into atmel.
So I add a formal Acked-by from you?
Best regards
Andreas Bießmann
Hi Andreas,
On Tue, 04 Sep 2012 21:35:51 +0200, Andreas Bießmann andreas.devel@googlemail.com wrote:
Hi Albert,
On 04.09.12 21:34, Albert ARIBAUD wrote:
Hi Andreas,
On Tue, 04 Sep 2012 21:17:58 +0200, Andreas Bießmann andreas.devel@googlemail.com wrote:
Dear Albert Aribaud,
On 16.08.12 20:22, Markus Hubig wrote:
The board_postclk_init() function can be used to perform operations that requires a working timer early within the U-Boot init_sequence.
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Albert ARIBAUD albert.u.boot@aribaud.net
arch/arm/lib/board.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index f1951e8..109a1ac 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -241,6 +241,9 @@ init_fnc_t *init_sequence[] = { fdtdec_check_fdt, #endif timer_init, /* initialize timer */ +#ifdef CONFIG_BOARD_POSTCLK_INIT
- board_postclk_init,
+#endif #ifdef CONFIG_FSL_ESDHC get_clocks, #endif
how do you think about this suggestion? Will you accept it? Should I apply both patches to u-boot-atmel?
From what I see, this converges with what's been in PPC for a long time... I'm ok with the series going into atmel.
So I add a formal Acked-by from you?
That or just go ahead and apply them to atmel; as the custodian, you don't need my Acked-By.
Best regards
Andreas Bießmann
Amicalement,
Dear Markus Hubig,
On 16.08.2012 20:22, Markus Hubig wrote:
The board_postclk_init() function can be used to perform operations that requires a working timer early within the U-Boot init_sequence.
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Albert ARIBAUD albert.u.boot@aribaud.net
applied to u-boot-atmel/master, thanks!
Best regards
Andreas Bießmann
In order to use the serial interface on the PortuxG20 we need to enable the level converter first by setting the PC9 pin to high. The level converter needs some time to settle so we have to use the mdelay() function to wait for some time. Unfortunately we have no timers available at board_early_init_f() so we enable the serial output early within board_postclk_init().
Now the U-Boot output looks fine:
| U-Boot 2012.07-00132-gaf1a3b0-dirty (Aug 16 2012 - 18:21:32) | | CPU: AT91SAM9G20 | Crystal frequency: 18.432 MHz | CPU clock : 396.288 MHz | Master clock : 132.096 MHz | DRAM: 64 MiB | WARNING: Caches not enabled | NAND: 128 MiB | In: serial | Out: serial | Err: serial | Net: macb0 | Hit any key to stop autoboot: 0
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Andreas Bießmann andreas.devel@googlemail.com --- board/taskit/stamp9g20/stamp9g20.c | 21 +++++++++++++++++---- include/configs/stamp9g20.h | 1 + 2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/board/taskit/stamp9g20/stamp9g20.c b/board/taskit/stamp9g20/stamp9g20.c index 5e07bf8..06df0af 100644 --- a/board/taskit/stamp9g20/stamp9g20.c +++ b/board/taskit/stamp9g20/stamp9g20.c @@ -159,15 +159,28 @@ int board_early_init_f(void) return 0; }
-int board_init(void) +int board_postclk_init(void) { - /* Adress of boot parameters */ - gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100; + /* + * Initialize the serial interface here, because be need a running + * timer to set PC9 to high and wait for some time to enable the + * level converter of the RS232 interface on the PortuxG20 board. + */
- /* Enable the serial interface */ +#ifdef CONFIG_PORTUXG20 at91_set_gpio_output(AT91_PIN_PC9, 1); + mdelay(1); +#endif at91_seriald_hw_init();
+ return 0; +} + +int board_init(void) +{ + /* Adress of boot parameters */ + gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100; + stamp9G20_nand_hw_init(); #ifdef CONFIG_MACB stamp9G20_macb_hw_init(); diff --git a/include/configs/stamp9g20.h b/include/configs/stamp9g20.h index a2a0156..a881eef 100644 --- a/include/configs/stamp9g20.h +++ b/include/configs/stamp9g20.h @@ -59,6 +59,7 @@ #define CONFIG_INITRD_TAG /* pass initrd param to kernel */ #define CONFIG_SKIP_LOWLEVEL_INIT /* U-Boot is loaded by a bootloader */ #define CONFIG_BOARD_EARLY_INIT_f /* call board_early_init_f() */ +#define CONFIG_BOARD_POSTCLK_INIT /* call board_postclk_init() */ #define CONFIG_DISPLAY_CPUINFO /* display CPU Info at startup */
/* setting board specific options */
Dear Markus Hubig,
On 16.08.2012 20:22, Markus Hubig wrote:
In order to use the serial interface on the PortuxG20 we need to enable the level converter first by setting the PC9 pin to high. The level converter needs some time to settle so we have to use the mdelay() function to wait for some time. Unfortunately we have no timers available at board_early_init_f() so we enable the serial output early within board_postclk_init().
Now the U-Boot output looks fine:
| U-Boot 2012.07-00132-gaf1a3b0-dirty (Aug 16 2012 - 18:21:32) | | CPU: AT91SAM9G20 | Crystal frequency: 18.432 MHz | CPU clock : 396.288 MHz | Master clock : 132.096 MHz | DRAM: 64 MiB | WARNING: Caches not enabled | NAND: 128 MiB | In: serial | Out: serial | Err: serial | Net: macb0 | Hit any key to stop autoboot: 0
Signed-off-by: Markus Hubig mhubig@imko.de Cc: Andreas Bießmann andreas.devel@googlemail.com
applied to u-boot-atmel/master, thanks!
Best regards
Andreas Bießmann
Hello Albert, hello Andreas,
any news if this two patches can get accepted?
Cheers, Markus
On Thu, Aug 16, 2012 at 8:22 PM, Markus Hubig mhubig@imko.de wrote:
In order to use the serial interface on the PortuxG20 we need to enable the level converter first by setting the PC9 pin to high. The level converter needs some time to settle so we have to use the mdelay() function to wait for some time. Unfortunately we have no timers available at board_early_init_f() so we enable the serial output early within board_postclk_init().
Unfortunately the board_postclk_init() function was not called in the init_sequence of arch/arm/lib/board.c so the first patch will added it there.
Markus Hubig (2): arm: Adds board_postclk_init to the init_sequence. Fixes the crippled console output on PortuxG20.
arch/arm/lib/board.c | 3 +++ board/taskit/stamp9g20/stamp9g20.c | 21 +++++++++++++++++---- include/configs/stamp9g20.h | 1 + 3 files changed, 21 insertions(+), 4 deletions(-)
-- 1.7.7
Dear Markus Hubig,
On 31.08.2012 14:36, Markus Hubig wrote:
Hello Albert, hello Andreas,
any news if this two patches can get accepted?
I'm waiting for Albert's comment. I did force Albert to accept a change albeit he had objections by sending some Ack-by before. I promised to never do this again ;)
@Albert: ping?
Best regards
Andreas Bießmann
participants (3)
-
Albert ARIBAUD -
Andreas Bießmann -
Markus Hubig