[U-Boot] Invalid Netconsole source MAC address [was: Re: [STATUS] v2012.07-rc1 is out - release date July 23]
Hi,
Am Dienstag 10 Juli 2012, 09:31:42 schrieb Wolfgang Denk:
Hi everybody,
this is to let you know that the v2012.07-rc1 prerelease is out.
Please help testing, so we can fix the remaining issues before the release, which I decided to shift by a week, i. e. the new schedule for the release is July 23.
I just noticed, that netconsole isnt working anymore for stdout. The source mac address is set to 00:00:00:00:00:00 in the udp packet which is sent by u- boot :(
But haven't figured out yet why it NetOurEther isn't initialized.
@Joe: would be nice if the fix would make it into this release.
Mh i guess NetLoop isn't called and thus NetOurEther is never initialized. Similar issue like d7310c7e63ca9ffd42527dc9735cb505cbe908b7. Initializing NetOurEther in net_init() fixes the problem.
Hi Michael,
On Sat, Jul 21, 2012 at 1:04 PM, Michael Walle michael@walle.cc wrote:
Hi,
Am Dienstag 10 Juli 2012, 09:31:42 schrieb Wolfgang Denk:
Hi everybody,
this is to let you know that the v2012.07-rc1 prerelease is out.
Please help testing, so we can fix the remaining issues before the release, which I decided to shift by a week, i. e. the new schedule for the release is July 23.
I just noticed, that netconsole isnt working anymore for stdout. The source mac address is set to 00:00:00:00:00:00 in the udp packet which is sent by u- boot :(
But haven't figured out yet why it NetOurEther isn't initialized.
@Joe: would be nice if the fix would make it into this release.
Mh i guess NetLoop isn't called and thus NetOurEther is never initialized. Similar issue like d7310c7e63ca9ffd42527dc9735cb505cbe908b7. Initializing NetOurEther in net_init() fixes the problem.
I tested this on Panda board and wireshark reports the correct source MAC address.
Please provide details of which board and driver you are using.
Thanks, -Joe
Hi Joe,
Am Montag 23 Juli 2012, 21:30:28 schrieb Joe Hershberger:
On Sat, Jul 21, 2012 at 1:04 PM, Michael Walle michael@walle.cc wrote:
Mh i guess NetLoop isn't called and thus NetOurEther is never initialized. Similar issue like d7310c7e63ca9ffd42527dc9735cb505cbe908b7. Initializing NetOurEther in net_init() fixes the problem.
I tested this on Panda board and wireshark reports the correct source MAC address.
Please provide details of which board and driver you are using.
Board: LS-CHLv2/kirkwood arm; ethaddr set to some valid ethernet address ;)
If NetLoop isn't called the internal ethernet address is not initialized. Hopefully the following sequence triggers the bug: - boot the board, _dont_ do any network interaction - setenv stdout nc - type sth on the serial console
--> now the packets are send with source MAC == 00:00:00:00:00:00.
If you look at the code NetOurEther is only initialized in NetLoop and i guess NetLoop() isn't called for outgoing NetConsole packets.
Hi Michael,
On Mon, Jul 23, 2012 at 3:41 PM, Michael Walle michael@walle.cc wrote:
Hi Joe,
Am Montag 23 Juli 2012, 21:30:28 schrieb Joe Hershberger:
On Sat, Jul 21, 2012 at 1:04 PM, Michael Walle michael@walle.cc wrote:
Mh i guess NetLoop isn't called and thus NetOurEther is never initialized. Similar issue like d7310c7e63ca9ffd42527dc9735cb505cbe908b7. Initializing NetOurEther in net_init() fixes the problem.
I tested this on Panda board and wireshark reports the correct source MAC address.
Please provide details of which board and driver you are using.
Board: LS-CHLv2/kirkwood arm; ethaddr set to some valid ethernet address ;)
If NetLoop isn't called the internal ethernet address is not initialized. Hopefully the following sequence triggers the bug:
- boot the board, _dont_ do any network interaction
- setenv stdout nc
- type sth on the serial console
--> now the packets are send with source MAC == 00:00:00:00:00:00.
If you look at the code NetOurEther is only initialized in NetLoop and i guess NetLoop() isn't called for outgoing NetConsole packets.
Thanks for pointing this out. I was able to reproduce it on panda and have a fix for it. I'll post it shortly.
-Joe
participants (2)
-
Joe Hershberger -
Michael Walle