Re: [U-Boot] Please pull u-boot-sparc.git
Just a codeing-style question, I have seen other writers of assembly code add an extra space before instruction executed in a delay-slot (typically after a branch for SPARC) just to make it clear that instruction is executed as well. I find that quite good and have adopted that habit too, is that allowed? Daniel On Wed, 26 May 2010 17:20:35 -0400, daniel@gaisler.com wrote:
On Wed, 26 May 2010 23:02:43 0200, Wolfgang Denk wrote: Dear Daniel Hellstrom,
In message 4BFD1176.6080702@gaisler.com you wrote:
Please pull the 17 patches in the master branch of u-boot-sparc repository. I have rebased the patches and updated the first patch according to Mike Drysingers comments.
Sorry, but I won't.
I have found a number of issues that need to be fixed first.
Sorry for the late review.
No problem, thank you for your comments, I will go through them. Best regards, Daniel Hellstrom
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: ( 49)-8142-66989-10 Fax: ( 49)-8142-66989-80 Email: wd@denx.de Overdrawn? But I still have checks left!
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Dear daniel@gaisler.com,
In message 20100526172855.2w3qpyvp3akgc884@webmail.bluegenesis.com you wrote:
Just a codeing-style question, I have seen other writers of assembly code add an extra space before instruction executed in a delay-slot (typically after a branch for SPARC) just to make it clear that instruction is executed as well. I find that quite good and have adopted that habit too, is that allowed?
Ah, that was the meaning. I thought so initially, but then saw a lot of empty lines separating such blocks, so I assumed it was just incorrect indentation.
When this is used consistently through all of the code (at least in the changed files), than it's OK with me.
Ideally it should be documented.
Best regards,
Wolfgang Denk
participants (2)
-
daniel＠gaisler.com -
Wolfgang Denk