[U-Boot] Commit 2108f4c4 causes a warning in 10 ARM boards
Hi Rob,
Commit 2108f4c4 ("config: consolidate CONFIG_SYS_HZ definition") causes the following boards:
omap730p2_cs3boot omap730p2_cs0boot scb9328 palmtc balloon3 mini2440 zipitz2 palmld omap730p2 omap3_zoom2 mx1ads
to emit this warning:
time.c:12:2: warning: #warning "CONFIG_SYS_HZ must be 1000 and should not be defined by platforms" [-Wcpp]
Rob, can you look into it?
Tom: I am preparing a PR from ARM to u-boot; ARM build will obviously fail for these 10 boards unless a fix is applied to u-boot/master before I submit my PR.
Amicalement,
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 11/09/2013 04:49 AM, Albert ARIBAUD wrote:
Hi Rob,
Commit 2108f4c4 ("config: consolidate CONFIG_SYS_HZ definition") causes the following boards:
omap730p2_cs3boot omap730p2_cs0boot scb9328 palmtc balloon3 mini2440 zipitz2 palmld omap730p2 omap3_zoom2 mx1ads
to emit this warning:
time.c:12:2: warning: #warning "CONFIG_SYS_HZ must be 1000 and should not be defined by platforms" [-Wcpp]
Rob, can you look into it?
Tom: I am preparing a PR from ARM to u-boot; ARM build will obviously fail for these 10 boards unless a fix is applied to u-boot/master before I submit my PR.
This is intentional, as those boards have CONFIG_SYS_HZ wrong. For the PXA boards, Marek posted a patch that fixes them. For omap730p2* I plan to submit a patch to just yank them out. For the others, we need to find the board maintainer and get them to correct things, or pull them as well.
- -- Tom
Hi Tom,
On Sat, 9 Nov 2013 07:18:23 -0500, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 11/09/2013 04:49 AM, Albert ARIBAUD wrote:
Hi Rob,
Commit 2108f4c4 ("config: consolidate CONFIG_SYS_HZ definition") causes the following boards:
omap730p2_cs3boot omap730p2_cs0boot scb9328 palmtc balloon3 mini2440 zipitz2 palmld omap730p2 omap3_zoom2 mx1ads
to emit this warning:
time.c:12:2: warning: #warning "CONFIG_SYS_HZ must be 1000 and should not be defined by platforms" [-Wcpp]
Rob, can you look into it?
Tom: I am preparing a PR from ARM to u-boot; ARM build will obviously fail for these 10 boards unless a fix is applied to u-boot/master before I submit my PR.
This is intentional, as those boards have CONFIG_SYS_HZ wrong. For the PXA boards, Marek posted a patch that fixes them. For omap730p2* I plan to submit a patch to just yank them out. For the others, we need to find the board maintainer and get them to correct things, or pull them as well.
OK -- sorry for the noise, then.
Amicalement,
participants (2)
-
Albert ARIBAUD -
Tom Rini