[U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
There is some dead code enclosed by #if 0 .... #endif in the file common/cmd_i2c.c This patch removes the dead code.
Signed-off-by: Pratap Chandu pratap.rrke@gmail.com --- common/cmd_i2c.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c index 8f0fc9e..8d6feda 100644 --- a/common/cmd_i2c.c +++ b/common/cmd_i2c.c @@ -326,14 +326,6 @@ int do_i2c_mw ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) #if !defined(CONFIG_SYS_I2C_FRAM) udelay(11000); #endif - -#if 0 - for (timeout = 0; timeout < 10; timeout++) { - udelay(2000); - if (i2c_probe(chip) == 0) - break; - } -#endif }
return (0);
Dear Pratap Chandu,
In message 1258034305-31770-1-git-send-email-pratap.rrke@gmail.com you wrote:
There is some dead code enclosed by #if 0 .... #endif in the file common/cmd_i2c.c This patch removes the dead code.
Signed-off-by: Pratap Chandu pratap.rrke@gmail.com
common/cmd_i2c.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-)
Applied, thanks.
Heiko, I hope this is OK with you.
Best regards,
Wolfgang Denk
Hello Wolfgang,
Wolfgang Denk schrieb:
Dear Pratap Chandu,
In message 1258034305-31770-1-git-send-email-pratap.rrke@gmail.com you wrote:
There is some dead code enclosed by #if 0 .... #endif in the file common/cmd_i2c.c This patch removes the dead code.
Signed-off-by: Pratap Chandu pratap.rrke@gmail.com
common/cmd_i2c.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-)
Applied, thanks.
Heiko, I hope this is OK with you.
Hmm.. not really, my last comment on this was:
http://lists.denx.de/pipermail/u-boot/2009-November/064245.html
I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.
bye Heiko
Dear Heiko,
In message 4B175F3F.2060400@denx.de you wrote:
Applied, thanks.
Heiko, I hope this is OK with you.
Hmm.. not really, my last comment on this was:
Ouch, sorry.
http://lists.denx.de/pipermail/u-boot/2009-November/064245.html
I missed that, sorry. This was in another thread, not connected with the patch.
I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.
What do you suggest? Shall I revert the patch, or can you provide a new commit to re-add this feature? [But then, it would be unused code, which we don't want to add, right?]
Best regards,
Wolfgang Denk
Hello Wolfgang,
Wolfgang Denk wrote:
In message 4B175F3F.2060400@denx.de you wrote:
Applied, thanks.
Heiko, I hope this is OK with you.
Hmm.. not really, my last comment on this was:
Ouch, sorry.
No probelm.
http://lists.denx.de/pipermail/u-boot/2009-November/064245.html
I missed that, sorry. This was in another thread, not connected with the patch.
I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.
What do you suggest? Shall I revert the patch, or can you provide a new commit to re-add this feature? [But then, it would be unused code, which we don't want to add, right?]
I actually vote for removing the code, so I sent soon a patch, which fixes the comment.
bye Heiko
participants (3)
-
Heiko Schocher -
Pratap Chandu -
Wolfgang Denk