On Wed, Apr 18, 2007 at 09:59:51PM -0400, Jerry Van Baren wrote:

This makes padding out the blob if the user requested extra size much easer. The assembly and writing to the file is more straight forward too.

Signed-off-by: Gerald Van Baren vanbaren@cideas.com

Hi David, Jon,

I wasn't happy with David's suggestion on the -S handling. I also wasn't all that wild about how the blob was assembled and then written to the file piecemeal with "ad-hoc" alignment padding. I realized I could fix both by assembling the blob in memory as a "struct data" and then write the whole thing out in one fell swoop.

Makes it a lot simpler and cleaner to my eyes.

I like it. (In fact my original suggestion about using data_append_zeroes() was based on a mistaken vague notion that we already did it this way).

Acked-by: David Gibson david@gibson.dropbear.id.au