[U-Boot] [PATCH] mx28evk: add trimffs to nand command

this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)
Signed-off-by: Eric Bénard eric@eukrea.com --- include/configs/mx28evk.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index d470b47..b22a20b 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -63,6 +63,7 @@ #define CONFIG_CMD_USB #define CONFIG_CMD_BOOTZ #define CONFIG_CMD_NAND +#define CONFIG_CMD_NAND_TRIMFFS
/* Memory configurations */ #define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */

On Mon, Apr 8, 2013 at 3:59 PM, Eric Bénard eric@eukrea.com wrote:
this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)
Signed-off-by: Eric Bénard eric@eukrea.com
Acked-by: Otavio Salvador otavio@ossystems.com.br
-- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

Eric Bénard wrote:
this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)
Signed-off-by: Eric Bénard eric@eukrea.com
include/configs/mx28evk.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index d470b47..b22a20b 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -63,6 +63,7 @@ #define CONFIG_CMD_USB #define CONFIG_CMD_BOOTZ #define CONFIG_CMD_NAND +#define CONFIG_CMD_NAND_TRIMFFS
You should add this into mx28evk_nand.h, available in u-boot.imx tree.

Hi Fabio,
Le Tue, 9 Apr 2013 15:02:44 -0300, Fabio Estevam fabio.estevam@freescale.com a écrit :
Eric Bénard wrote:
this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)
Signed-off-by: Eric Bénard eric@eukrea.com
include/configs/mx28evk.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index d470b47..b22a20b 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -63,6 +63,7 @@ #define CONFIG_CMD_USB #define CONFIG_CMD_BOOTZ #define CONFIG_CMD_NAND +#define CONFIG_CMD_NAND_TRIMFFS
You should add this into mx28evk_nand.h, available in u-boot.imx tree.
that's the second time you ask this but mx28evk_nand.h doesn't exist, even in u-boot-imx tree, and you are the developer who added nand support to mx28evk in commit ab461be65dbfe3e2fa45f7cd836faa99663be5bb ;-)
Here is a reminder of what you did in that commit : you added the mx28evk_nand option in boards.cfg which defines ENV_IS_IN_NAND when mx28evk defines ENV_IS_IN_MMC and both are using the same config which is include/configs/mx28evk.h : http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=ab461be65dbfe3e2f...
So this patch is fine against u-boot-imx.
Best regards Eric

Hi Eric,
On Tue, Apr 9, 2013 at 4:21 PM, Eric Bénard eric@eukrea.com wrote:
that's the second time you ask this but mx28evk_nand.h doesn't exist, even in u-boot-imx tree, and you are the developer who added nand support to mx28evk in commit ab461be65dbfe3e2fa45f7cd836faa99663be5bb ;-)
Right, mx28_evk.h only existed in my first version of the patch, and then the patch I submitted handles both ENV_IS_NAND and ENV_IS_MMC with the same config file.
Sorry for the confusion :-)

On 08/04/2013 20:59, Eric Bénard wrote:
this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)
Signed-off-by: Eric Bénard eric@eukrea.com
Applied to u-boot-imx, -next branch, thanks.
Best regards, Stefano Babic
participants (5)
-
Eric Bénard
-
Fabio Estevam
-
Fabio Estevam
-
Otavio Salvador
-
Stefano Babic