[PATCH v3 0/4] Various i.MXRT bug/typo fixes
Hi Anatolij, Lukasz, Stefano, Fabio, All,
this patchset fix 2 bugs preventing from LCDIF to work when booting from sd-card. There are also 2 little typo fixes for boards READMEs.
V1->V2: * modify mxfsb.c patch as suggested by Fabio V2->V3: * change /dev/sdb into /dev/sdX as suggested by Fabio
Giulio Benetti (4): imxrt1050-evk: README: change dd command destination imxrt1020-evk: README: change dd command destination video: mxsfb: add clk_enable() clk: imx: clk-imxrt1050: fix lcdif clock gate
board/freescale/imxrt1020-evk/README | 4 ++-- board/freescale/imxrt1050-evk/README | 4 ++-- drivers/clk/imx/clk-imxrt1050.c | 2 +- drivers/video/mxsfb.c | 6 ++++++ 4 files changed, 11 insertions(+), 5 deletions(-)
Set dd "of=" to "of=/dev/sdX" to be generic and prevent host hard drive damage.
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com --- V2->V3: * change /dev/sdb to /dev/sdX as suggested by Fabio --- board/freescale/imxrt1050-evk/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README index f7e2894025..a7e68fa9b3 100644 --- a/board/freescale/imxrt1050-evk/README +++ b/board/freescale/imxrt1050-evk/README @@ -11,11 +11,11 @@ This will generate the SPL image called SPL and the u-boot.img.
- Flash the SPL image into the micro SD card:
-sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync +sudo dd if=SPL of=/dev/sdX bs=1k seek=1; sync
- Flash the u-boot.img image into the micro SD card:
-sudo dd if=u-boot.img of=/dev/sdb bs=1k seek=128; sync +sudo dd if=u-boot.img of=/dev/sdX bs=1k seek=128; sync
- Jumper settings:
Set dd "of=" to "of=/dev/sdX" to be generic and prevent host hard drive damage. Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
Set dd "of=" to "of=/dev/sdX" to be generic and prevent host hard drive damage.
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com --- V2->V3: * change /dev/sdb to /dev/sdX as suggested by Fabio --- board/freescale/imxrt1020-evk/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/imxrt1020-evk/README b/board/freescale/imxrt1020-evk/README index 3da72fdad2..abee7ca5f3 100644 --- a/board/freescale/imxrt1020-evk/README +++ b/board/freescale/imxrt1020-evk/README @@ -11,11 +11,11 @@ This will generate the SPL image called SPL and the u-boot.img.
- Flash the SPL image into the micro SD card:
-sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync +sudo dd if=SPL of=/dev/sdX bs=1k seek=1; sync
- Flash the u-boot.img image into the micro SD card:
-sudo dd if=u-boot.img of=/dev/sdb bs=1k seek=128; sync +sudo dd if=u-boot.img of=/dev/sdX bs=1k seek=128; sync
- Jumper settings:
Set dd "of=" to "of=/dev/sdX" to be generic and prevent host hard drive damage. Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
BROM doesn't enable lcdif by default so add clk_enable() after clk_set_rate().
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com --- V1->V2: * call clk_enable() after clk_set_rate() as suggested by Fabio --- drivers/video/mxsfb.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 8a5a61c9fb..12d00b4689 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -77,6 +77,12 @@ static void mxs_lcd_init(struct udevice *dev, u32 fb_addr, dev_err(dev, "Failed to set mxs clk: %d\n", ret); return; } + + ret = clk_enable(&per_clk); + if (ret < 0) { + dev_err(dev, "Failed to enable mxs clk: %d\n", ret); + return; + } #else /* Kick in the LCDIF clock */ mxs_set_lcdclk(MXS_LCDIF_BASE, timings->pixelclock.typ / 1000);
Forgotten to add
On 4/27/20 5:53 PM, Giulio Benetti wrote:
BROM doesn't enable lcdif by default so add clk_enable() after clk_set_rate().
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
Reviewed-by: Anatolij Gustschin agust@denx.de Reviewed-by: Fabio Estevam festevam@gmail.com
V1->V2:
- call clk_enable() after clk_set_rate() as suggested by Fabio
drivers/video/mxsfb.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 8a5a61c9fb..12d00b4689 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -77,6 +77,12 @@ static void mxs_lcd_init(struct udevice *dev, u32 fb_addr, dev_err(dev, "Failed to set mxs clk: %d\n", ret); return; }
- ret = clk_enable(&per_clk);
- if (ret < 0) {
dev_err(dev, "Failed to enable mxs clk: %d\n", ret);return;- } #else /* Kick in the LCDIF clock */ mxs_set_lcdclk(MXS_LCDIF_BASE, timings->pixelclock.typ / 1000);
BROM doesn't enable lcdif by default so add clk_enable() after clk_set_rate(). Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com Reviewed-by: Anatolij Gustschin agust@denx.de Reviewed-by: Fabio Estevam festevam@gmail.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
LCDIF clock gate was wrong so set it according to RM.
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com --- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c index 329f4580c5..8279e784fe 100644 --- a/drivers/clk/imx/clk-imxrt1050.c +++ b/drivers/clk/imx/clk-imxrt1050.c @@ -255,7 +255,7 @@ static int imxrt1050_clk_probe(struct udevice *dev) clk_dm(IMXRT1050_CLK_SEMC, imx_clk_gate2("semc", "semc_podf", base + 0x74, 4)); clk_dm(IMXRT1050_CLK_LCDIF, - imx_clk_gate2("lcdif", "lcdif_podf", base + 0x70, 28)); + imx_clk_gate2("lcdif", "lcdif_podf", base + 0x74, 10));
struct clk *clk, *clk1;
Forgotten to add
On 4/27/20 5:53 PM, Giulio Benetti wrote:
LCDIF clock gate was wrong so set it according to RM.
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
Reviewed-by: Anatolij Gustschin agust@denx.de Reviewed-by: Fabio Estevam festevam@gmail.com
drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c index 329f4580c5..8279e784fe 100644 --- a/drivers/clk/imx/clk-imxrt1050.c +++ b/drivers/clk/imx/clk-imxrt1050.c @@ -255,7 +255,7 @@ static int imxrt1050_clk_probe(struct udevice *dev) clk_dm(IMXRT1050_CLK_SEMC, imx_clk_gate2("semc", "semc_podf", base + 0x74, 4)); clk_dm(IMXRT1050_CLK_LCDIF,
imx_clk_gate2("lcdif", "lcdif_podf", base + 0x70, 28));
imx_clk_gate2("lcdif", "lcdif_podf", base + 0x74, 10));struct clk *clk, *clk1;
LCDIF clock gate was wrong so set it according to RM. Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com Reviewed-by: Anatolij Gustschin agust@denx.de Reviewed-by: Fabio Estevam festevam@gmail.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
Hi Giulio,
On Mon, Apr 27, 2020 at 12:53 PM Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Anatolij, Lukasz, Stefano, Fabio, All,
this patchset fix 2 bugs preventing from LCDIF to work when booting from sd-card. There are also 2 little typo fixes for boards READMEs.
V1->V2:
- modify mxfsb.c patch as suggested by Fabio
V2->V3:
- change /dev/sdb into /dev/sdX as suggested by Fabio
For the whole series:
Reviewed-by: Fabio Estevam festevam@gmail.com
Just a hint for future submissions: when you re-submit a series, please keep the Reviewed-by tags that you received.
Thanks
On 4/27/20 5:57 PM, Fabio Estevam wrote:
Hi Giulio,
On Mon, Apr 27, 2020 at 12:53 PM Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Anatolij, Lukasz, Stefano, Fabio, All,
this patchset fix 2 bugs preventing from LCDIF to work when booting from sd-card. There are also 2 little typo fixes for boards READMEs.
V1->V2:
- modify mxfsb.c patch as suggested by Fabio
V2->V3:
- change /dev/sdb into /dev/sdX as suggested by Fabio
For the whole series:
Reviewed-by: Fabio Estevam festevam@gmail.com
Just a hint for future submissions: when you re-submit a series, please keep the Reviewed-by tags that you received.
Yes, I've missed it sorry and re-sent 2 answers to integrate.
Thank you very much
Best regards
participants (3)
-
Fabio Estevam -
Giulio Benetti -
sbabic＠denx.de