[PATCH] ls1028a: fix EFI boot
scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn’t work. Fix this issue by adding scan_dev_for_efi call.
Signed-off-by: Mian Yousaf Kaukab ykaukab@suse.de --- include/configs/ls1028aqds.h | 1 + include/configs/ls1028ardb.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/include/configs/ls1028aqds.h b/include/configs/ls1028aqds.h index 7bb740f48e36..3d622002ebca 100644 --- a/include/configs/ls1028aqds.h +++ b/include/configs/ls1028aqds.h @@ -135,6 +135,7 @@ "for prefix in ${boot_prefixes}; do " \ "run scan_dev_for_scripts; " \ "done;" \ + SCAN_DEV_FOR_EFI \ "\0" \ "boot_a_script=" \ "load ${devtype} ${devnum}:${distro_bootpart} " \ diff --git a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h index 07450113269c..0064c1dcc01a 100644 --- a/include/configs/ls1028ardb.h +++ b/include/configs/ls1028ardb.h @@ -118,6 +118,7 @@ "for prefix in ${boot_prefixes}; do " \ "run scan_dev_for_scripts; " \ "done;" \ + SCAN_DEV_FOR_EFI \ "\0" \ "boot_a_script=" \ "load ${devtype} ${devnum}:${distro_bootpart} " \
Hello Yousaf
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Mian Yousaf Kaukab Sent: Tuesday, July 21, 2020 8:04 PM To: u-boot@lists.denx.de; Rajesh Bhagat rajesh.bhagat@nxp.com; harninder.rai@nxp.com; sudhanshu.gupta@nxp.com Cc: prabhakar.kushwaha@nxp.com; Andy Tang andy.tang@nxp.com; Priyanka Jain priyanka.jain@nxp.com; Mian Yousaf Kaukab ykaukab@suse.de Subject: [PATCH] ls1028a: fix EFI boot
scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn’t work. Fix this issue by adding scan_dev_for_efi call.
Acked.
Andy, can you please also take a look.
Thanks .
Regards Poonam
Signed-off-by: Mian Yousaf Kaukab ykaukab@suse.de
include/configs/ls1028aqds.h | 1 + include/configs/ls1028ardb.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/include/configs/ls1028aqds.h b/include/configs/ls1028aqds.h index 7bb740f48e36..3d622002ebca 100644 --- a/include/configs/ls1028aqds.h +++ b/include/configs/ls1028aqds.h @@ -135,6 +135,7 @@ "for prefix in ${boot_prefixes}; do " \ "run scan_dev_for_scripts; " \ "done;" \
SCAN_DEV_FOR_EFI \a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h index 07450113269c..0064c1dcc01a 100644 --- a/include/configs/ls1028ardb.h +++ b/include/configs/ls1028ardb.h @@ -118,6 +118,7 @@ "for prefix in ${boot_prefixes}; do " \ "run scan_dev_for_scripts; " \ "done;" \
SCAN_DEV_FOR_EFI \-- 2.26.2
Hi Yousaf,
Could you please try removing entire environment variable "scan_dev_for_boot" in the ls1028aqds/rdb header file? In this way, the default value for scan_dev_for_boot could be used and meet your requirement.
BR, Andy
-----Original Message----- From: Poonam Aggrwal poonam.aggrwal@nxp.com Sent: 2020年7月22日 18:01 To: Mian Yousaf Kaukab ykaukab@suse.de; u-boot@lists.denx.de; Rajesh Bhagat rajesh.bhagat@nxp.com; harninder.rai@nxp.com; sudhanshu.gupta@nxp.com Cc: prabhakar.kushwaha@nxp.com; Andy Tang andy.tang@nxp.com; Priyanka Jain priyanka.jain@nxp.com Subject: RE: [PATCH] ls1028a: fix EFI boot
Hello Yousaf
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Mian Yousaf Kaukab Sent: Tuesday, July 21, 2020 8:04 PM To: u-boot@lists.denx.de; Rajesh Bhagat rajesh.bhagat@nxp.com; harninder.rai@nxp.com; sudhanshu.gupta@nxp.com Cc: prabhakar.kushwaha@nxp.com; Andy Tang andy.tang@nxp.com; Priyanka Jain priyanka.jain@nxp.com; Mian Yousaf Kaukab ykaukab@suse.de Subject: [PATCH] ls1028a: fix EFI boot
scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn’t work. Fix this issue by adding scan_dev_for_efi
call.
Acked.
Andy, can you please also take a look.
Thanks .
Regards Poonam
Signed-off-by: Mian Yousaf Kaukab ykaukab@suse.de
include/configs/ls1028aqds.h | 1 + include/configs/ls1028ardb.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/include/configs/ls1028aqds.h b/include/configs/ls1028aqds.h index 7bb740f48e36..3d622002ebca
100644
--- a/include/configs/ls1028aqds.h +++ b/include/configs/ls1028aqds.h @@ -135,6 +135,7 @@ "for prefix in ${boot_prefixes}; do " \ "run scan_dev_for_scripts; " \ "done;" \
SCAN_DEV_FOR_EFI \a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h index 07450113269c..0064c1dcc01a 100644 --- a/include/configs/ls1028ardb.h +++ b/include/configs/ls1028ardb.h @@ -118,6 +118,7 @@ "for prefix in ${boot_prefixes}; do " \ "run scan_dev_for_scripts; " \ "done;" \
SCAN_DEV_FOR_EFI \-- 2.26.2
On Thu, Jul 23, 2020 at 06:26:38AM +0000, Andy Tang wrote:
Hi Yousaf,
Hi Andy,
Could you please try removing entire environment variable "scan_dev_for_boot" in the ls1028aqds/rdb header file? In this way, the default value for scan_dev_for_boot could be used and meet your requirement.
Its actually better to remove the custom definition of scan_dev_for_boot. However, the default definition will additionally call “run scan_dev_for_extlinux”. I can send a new patch if that's not an issue.
BR, Andy
BR, Yousaf
-----Original Message----- From: Mian Yousaf Kaukab ykaukab@suse.de Sent: 2020年7月23日 17:31 To: Andy Tang andy.tang@nxp.com Cc: Poonam Aggrwal poonam.aggrwal@nxp.com; u-boot@lists.denx.de; Rajesh Bhagat rajesh.bhagat@nxp.com; harninder.rai@nxp.com; sudhanshu.gupta@nxp.com; prabhakar.kushwaha@nxp.com; Priyanka Jain priyanka.jain@nxp.com Subject: [EXT] Re: [PATCH] ls1028a: fix EFI boot
Caution: EXT Email
On Thu, Jul 23, 2020 at 06:26:38AM +0000, Andy Tang wrote:
Hi Yousaf,
Hi Andy,
Could you please try removing entire environment variable
"scan_dev_for_boot" in the ls1028aqds/rdb header file?
In this way, the default value for scan_dev_for_boot could be used and meet
your requirement. Its actually better to remove the custom definition of scan_dev_for_boot. However, the default definition will additionally call “run scan_dev_for_extlinux”. I can send a new patch if that's not an issue.
Go ahead, that should not be an issue.
BR, Andy
BR, Andy
BR, Yousaf
participants (3)
-
Andy Tang -
Mian Yousaf Kaukab -
Poonam Aggrwal