[U-Boot] [ppc4xx] Please pull git://www.denx.de/git/u-boot-ppc4xx.git
The following changes since commit c0d2f87d6c450128b88e73eea715fa3654f65b6c: Wolfgang Denk (1): Prepare v2008.10-rc2
are available in the git repository at:
git://www.denx.de/git/u-boot-ppc4xx.git master
Victor Gallardo (1): ppc4xx: Fix DDR2 auto calibration on Kilauea 600MHz (200MHz PLB)
board/amcc/kilauea/kilauea.c | 31 +++++++++++++++++++++++++++++++ cpu/ppc4xx/4xx_ibm_ddr2_autocalib.c | 5 ----- include/asm-ppc/ppc4xx-sdram.h | 6 ++++++ 3 files changed, 37 insertions(+), 5 deletions(-)
Dear Stefan Roese,
In message 200809162019.27303.sr@denx.de you wrote:
The following changes since commit c0d2f87d6c450128b88e73eea715fa3654f65b6c: Wolfgang Denk (1): Prepare v2008.10-rc2
are available in the git repository at:
git://www.denx.de/git/u-boot-ppc4xx.git master
Victor Gallardo (1): ppc4xx: Fix DDR2 auto calibration on Kilauea 600MHz (200MHz PLB)
I'm not really happy abouthtis. AS I understand, this is just a temporary patch including a workaround for aproblem that is not yet understood.
We are not under preassure yet in terms of release schedule.
Wouldn't it be better to delay this until we have the final patch without such a workaround?
Best regards,
Wolfgang Denk
Hi Wolfgang,
On Tuesday 16 September 2008, Wolfgang Denk wrote:
The following changes since commit c0d2f87d6c450128b88e73eea715fa3654f65b6c: Wolfgang Denk (1): Prepare v2008.10-rc2
are available in the git repository at:
git://www.denx.de/git/u-boot-ppc4xx.git master
Victor Gallardo (1): ppc4xx: Fix DDR2 auto calibration on Kilauea 600MHz (200MHz PLB)
I'm not really happy abouthtis.
I'm not either.
AS I understand, this is just a temporary patch including a workaround for aproblem that is not yet understood.
Correct.
We are not under preassure yet in terms of release schedule.
AMCC wants to ship the new 600MHz boards. This version at least works compared to the current version which turns those boards into bricks, since it doesn't bootup into the U-Boot prompt. So it definitely is an improvement.
Wouldn't it be better to delay this until we have the final patch without such a workaround?
I was hesitating here too, but I think its good enough to include this patch now. It definitely is a temporary fix and I hope that AMCC provides a "better", final patch that fixes this problem soon. Problem is that nobody knows how long this could take.
But in the end it's your call. If you reject this patch as is, then I'll revert it in my repository.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Dear Stefan,
in message 200809170600.21510.sr@denx.de you wrote:
AS I understand, this is just a temporary patch including a workaround for aproblem that is not yet understood.
Correct.
We are not under preassure yet in terms of release schedule.
AMCC wants to ship the new 600MHz boards. This version at least works compared to the current version which turns those boards into bricks, since it doesn't bootup into the U-Boot prompt. So it definitely is an improvement.
We agree on this. But I would rather wait for a real fix for mainline. In the meantime, you could keep this workaround in a separate branch of your ppc4xx repository.
I was hesitating here too, but I think its good enough to include this patch now. It definitely is a temporary fix and I hope that AMCC provides a "better", final patch that fixes this problem soon. Problem is that nobody knows how long this could take.
I hope AMCC can still make it for the next release - we still have nearly 3 weeks plus some time for final testing.
But in the end it's your call. If you reject this patch as is, then I'll revert it in my repository.
Please revert it in the master branch. Thanks.
Best regards,
Wolfgang Denk
Hi Wolfgang,
On Sunday 21 September 2008, Wolfgang Denk wrote:
AMCC wants to ship the new 600MHz boards. This version at least works compared to the current version which turns those boards into bricks, since it doesn't bootup into the U-Boot prompt. So it definitely is an improvement.
We agree on this. But I would rather wait for a real fix for mainline. In the meantime, you could keep this workaround in a separate branch of your ppc4xx repository.
This could be an option. I'll talk with AMCC about this.
I was hesitating here too, but I think its good enough to include this patch now. It definitely is a temporary fix and I hope that AMCC provides a "better", final patch that fixes this problem soon. Problem is that nobody knows how long this could take.
I hope AMCC can still make it for the next release - we still have nearly 3 weeks plus some time for final testing.
But in the end it's your call. If you reject this patch as is, then I'll revert it in my repository.
Please revert it in the master branch. Thanks.
Done.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
participants (2)
-
Stefan Roese -
Wolfgang Denk