[U-Boot-Users] Re: [PATCH]: tools/envcrc.c

In message 3E255A2B.7070009@sjtu.edu.cn you wrote:
In u-boot-0.2.0, the file "tools/envcrc.c" failed to consider the difference between "normal env" and "redundand env". It is a very obvious error.
The patch is in the attachment.
Please DO NOT DO THIS AGAIN!!!
First, you've sent this patch before. So on first glance this message seems redundant. But on second look your patch contains completely different things:
--- /download/project/u-boot-0.2.0/MAKEALL Tue Nov 5 23:32:56 2002 +++ embedded/code/u-boot-0.2.0/MAKEALL Tue Jan 14 22:20:41 2003
...
--- /download/project/u-boot-0.2.0/Makefile Sun Dec 8 06:32:52 2002 +++ embedded/code/u-boot-0.2.0/Makefile Tue Jan 14 22:22:35 2003
...
--- /download/project/u-boot-0.2.0/README Wed Dec 18 01:53:43 2002 +++ embedded/code/u-boot-0.2.0/README Tue Jan 14 22:06:11 2003 @@ -203,6 +203,8 @@
- board/pm826 Files specific to PM826 boards
- board/ppmc8260 Files specific to PPMC8260 boards
+- board/procard
Files specific to Motorola Processor Card
Ummm.. please be a _little_ bit more precise. I guess there is more than one "Motorola Processor Card" (a better directory name might be handy, too).
...
--- /download/project/u-boot-0.2.0/board/MAI/bios_emulator/scitech/lib/debug/linux/gcc/glibc.so/readme.txt Wed Oct 2 23:35:20 2002 +++ embedded/code/u-boot-0.2.0/board/MAI/bios_emulator/scitech/lib/debug/linux/gcc/glibc.so/readme.txt Thu Jan 1 08:00:00 1970 @@ -1 +0,0 @@ -This file is just to ensure that the directory is created.
Why the hell do you do this?
--- /download/project/u-boot-0.2.0/board/MAI/bios_emulator/scitech/lib/debug/linux/gcc/libc.so/readme.txt Wed Oct 2 23:35:20 2002 +++ embedded/code/u-boot-0.2.0/board/MAI/bios_emulator/scitech/lib/debug/linux/gcc/libc.so/readme.txt Thu Jan 1 08:00:00 1970
... etc.
REJECTED!!!!
Wolfgang Denk
participants (1)
-
Wolfgang Denk