Re: [U-Boot] [PATCH 1/1] riscv: allow native compilation
If environment variable CROSS_COMPILE is not set, this indicates native compilation. In this case we should not set an arbitrary value which is not applicable for 64bit anyway.
OK ! Thanks for your correction.
B.R
Rick
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
arch/riscv/config.mk | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index 219e66683d..f7a2ffbbc6 100644 --- a/arch/riscv/config.mk +++ b/arch/riscv/config.mk @@ -10,10 +10,6 @@ # Rick Chen, Andes Technology Corporation rick@andestech.com #
-ifeq ($(CROSS_COMPILE),) -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
32bit-emul := elf32lriscv 64bit-emul := elf64lriscv
On 08/07/2018 10:57 AM, Rick Chen wrote:
If environment variable CROSS_COMPILE is not set, this indicates native compilation. In this case we should not set an arbitrary value which is not applicable for 64bit anyway.
OK ! Thanks for your correction.
B.R
Rick
Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
Could you, please, consider the patch for your next pull request.
Best regards
Heinrich
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
arch/riscv/config.mk | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index 219e66683d..f7a2ffbbc6 100644 --- a/arch/riscv/config.mk +++ b/arch/riscv/config.mk @@ -10,10 +10,6 @@ # Rick Chen, Andes Technology Corporation rick@andestech.com #
-ifeq ($(CROSS_COMPILE),) -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
32bit-emul := elf32lriscv 64bit-emul := elf64lriscv
Heinrich Schuchardt xypron.glpk@gmx.de 於 2018年9月24日 週一 上午4:06寫道：
On 08/07/2018 10:57 AM, Rick Chen wrote:
If environment variable CROSS_COMPILE is not set, this indicates native compilation. In this case we should not set an arbitrary value which is not applicable for 64bit anyway.
OK ! Thanks for your correction.
B.R
Rick
Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
Could you, please, consider the patch for your next pull request.
Hi Heinrich
Sorry ! I was busy this period of time. And miss this time merge window.
I will merge it to git.denx.de/u-boot-riscv.git this week . And try to send pull request to Tom. Though I am not sure if it is legal to send pull request to Tom when the merge window was closed.
Rick
Best regards
Heinrich
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
arch/riscv/config.mk | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index 219e66683d..f7a2ffbbc6 100644 --- a/arch/riscv/config.mk +++ b/arch/riscv/config.mk @@ -10,10 +10,6 @@ # Rick Chen, Andes Technology Corporation rick@andestech.com #
-ifeq ($(CROSS_COMPILE),) -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
32bit-emul := elf32lriscv 64bit-emul := elf64lriscv
On Wed, Oct 03, 2018 at 09:16:48AM +0800, Rick Chen wrote:
Heinrich Schuchardt xypron.glpk@gmx.de 於 2018年9月24日 週一 上午4:06寫道：
On 08/07/2018 10:57 AM, Rick Chen wrote:
If environment variable CROSS_COMPILE is not set, this indicates native compilation. In this case we should not set an arbitrary value which is not applicable for 64bit anyway.
OK ! Thanks for your correction.
B.R
Rick
Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
Could you, please, consider the patch for your next pull request.
Hi Heinrich
Sorry ! I was busy this period of time. And miss this time merge window.
I will merge it to git.denx.de/u-boot-riscv.git this week . And try to send pull request to Tom. Though I am not sure if it is legal to send pull request to Tom when the merge window was closed.
With the window closed, yes, I want to see careful review taken by all custodians. But that doesn't mean nothing can go in. This looks reasonable to me, for example. Thanks!
Rick
Best regards
Heinrich
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
arch/riscv/config.mk | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index 219e66683d..f7a2ffbbc6 100644 --- a/arch/riscv/config.mk +++ b/arch/riscv/config.mk @@ -10,10 +10,6 @@ # Rick Chen, Andes Technology Corporation rick@andestech.com #
-ifeq ($(CROSS_COMPILE),) -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
32bit-emul := elf32lriscv 64bit-emul := elf64lriscv
Tom Rini trini@konsulko.com 於 2018年10月3日 週三 上午9:23寫道：
On Wed, Oct 03, 2018 at 09:16:48AM +0800, Rick Chen wrote:
Heinrich Schuchardt xypron.glpk@gmx.de 於 2018年9月24日 週一 上午4:06寫道：
On 08/07/2018 10:57 AM, Rick Chen wrote:
If environment variable CROSS_COMPILE is not set, this indicates native compilation. In this case we should not set an arbitrary value which is not applicable for 64bit anyway.
OK ! Thanks for your correction.
B.R
Rick
Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
Could you, please, consider the patch for your next pull request.
Hi Heinrich
Sorry ! I was busy this period of time. And miss this time merge window.
I will merge it to git.denx.de/u-boot-riscv.git this week . And try to send pull request to Tom. Though I am not sure if it is legal to send pull request to Tom when the merge window was closed.
With the window closed, yes, I want to see careful review taken by all custodians. But that doesn't mean nothing can go in. This looks reasonable to me, for example. Thanks!
Hi Tom
Got it. And thanks for your reply and explain.
Rick
Rick
Best regards
Heinrich
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
arch/riscv/config.mk | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index 219e66683d..f7a2ffbbc6 100644 --- a/arch/riscv/config.mk +++ b/arch/riscv/config.mk @@ -10,10 +10,6 @@ # Rick Chen, Andes Technology Corporation rick@andestech.com #
-ifeq ($(CROSS_COMPILE),) -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
32bit-emul := elf32lriscv 64bit-emul := elf64lriscv
-- Tom
participants (3)
-
Heinrich Schuchardt -
Rick Chen -
Tom Rini