Re: [U-Boot-Users] [PATCH] Make MPC83xx one step closer to full relocation.
On Sat, 29 Mar 2008 00:47:01 +0100 "Joakim Tjernlund" Joakim.Tjernlund@transmode.se wrote:
-----Original Message----- From: Kim Phillips [mailto:kim.phillips@freescale.com] Sent: den 29 mars 2008 00:33 To: Joakim Tjernlund Cc: u-boot-users@lists.sourceforge.net Subject: Re: [PATCH] Make MPC83xx one step closer to full relocation.
On Fri, 28 Mar 2008 15:41:25 +0100 Joakim Tjernlund Joakim.Tjernlund@transmode.se wrote:
Remove a few absolute references to CFG_MONITOR_BASE for ppc/mpc83xx and use GOT relative reference.
cpu/mpc83xx/start.S | 11 +++++++---- lib_ppc/board.c | 3 ++- 2 files changed, 9 insertions(+), 5 deletions(-)
Joakim,
this patch is missing your signoff, and doesn't apply cleanly (even adds whitespace).
It doesn't apply because you have been sitting on it for too long :) I sent long ago and you said would apply it in the next merge window, but seems to have forgotten about it. Sorry for the whitespace. I am still on the last u-boot release so I am afraid I can't do much about it ATM. I hope you can clean up the WS.
Signed-off-by: Joakim Tjernlund Joakim.Tjernlund@transmode.se
ok, I can add it now.
Kim
-----Original Message----- From: Kim Phillips [mailto:kim.phillips@freescale.com] Sent: den 29 mars 2008 01:01 To: Joakim Tjernlund Cc: u-boot-users@lists.sourceforge.net Subject: Re: [PATCH] Make MPC83xx one step closer to full relocation.
On Sat, 29 Mar 2008 00:47:01 +0100 "Joakim Tjernlund" Joakim.Tjernlund@transmode.se wrote:
-----Original Message----- From: Kim Phillips [mailto:kim.phillips@freescale.com] Sent: den 29 mars 2008 00:33 To: Joakim Tjernlund Cc: u-boot-users@lists.sourceforge.net Subject: Re: [PATCH] Make MPC83xx one step closer to full relocation.
On Fri, 28 Mar 2008 15:41:25 +0100 Joakim Tjernlund Joakim.Tjernlund@transmode.se wrote:
Remove a few absolute references to CFG_MONITOR_BASE for ppc/mpc83xx and use GOT relative reference.
cpu/mpc83xx/start.S | 11 +++++++---- lib_ppc/board.c | 3 ++- 2 files changed, 9 insertions(+), 5 deletions(-)
Joakim,
this patch is missing your signoff, and doesn't apply cleanly (even adds whitespace).
It doesn't apply because you have been sitting on it for too long :) I sent long ago and you said would apply it in the next merge window, but seems to have forgotten about it. Sorry for the whitespace. I am still on the last u-boot release so I am afraid I can't do much about it ATM. I hope you can clean up the WS.
Signed-off-by: Joakim Tjernlund Joakim.Tjernlund@transmode.se
ok, I can add it now.
Kim
Thanks, again sorry for the WS. Is there a git config option that implies -s to git format-patch ?:)
Jcoke
participants (2)
-
Joakim Tjernlund -
Kim Phillips