[U-Boot-Users] [patch] Fix NC650 nand support
Hi,
as noted in the subject attached a patch to fix the nand support for NC650 boards.
The 8xx custodian might also pull from my git repo on pollux :)
Cheers Detlev
Hi Detlev,
On Friday 20 April 2007 12:07, Detlev Zundel wrote:
as noted in the subject attached a patch to fix the nand support for NC650 boards.
You might want to clean up the compiler warnings too (ELDK 4.1)? ;-)
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany =====================================================================
In message 200704201338.51115.sr@denx.de you wrote:
You might want to clean up the compiler warnings too (ELDK 4.1)? ;-)
Done. [4.2 actually :-) ]
Best regards,
Wolfgang Denk
Hi Wolfgang,
In message 200704201338.51115.sr@denx.de you wrote:
You might want to clean up the compiler warnings too (ELDK 4.1)? ;-)
Done. [4.2 actually :-) ]
Hm. I am eager to see the changes. If you *really* cleaned *all* warnings then I am sure you also fixed the warning in extable.c and while doing this noticed that the whole fixup only works because we have a maximum of one fixup entry (./drivers/tsi108_pci.c, I cannot find any user of addr_probe anywhere). Otherwise the sorting of the table is missing and thus the searching with a bisecting algorithm will not work as is.
I am *really looking* forward to the patch fixing that :)
Cheers Detlev
In message m2irbr3wou.fsf@sowhat.denx.de you wrote:
Hm. I am eager to see the changes. If you *really* cleaned *all*
Not all, just those for the NC650 build.
warnings then I am sure you also fixed the warning in extable.c and
Indeed.
while doing this noticed that the whole fixup only works because we have a maximum of one fixup entry (./drivers/tsi108_pci.c, I cannot find any user of addr_probe anywhere). Otherwise the sorting of the table is missing and thus the searching with a bisecting algorithm will not work as is.
I didn'tnotice this, I just cleaned up the compiler warning.
I am *really looking* forward to the patch fixing that :)
Don't tell me, tell the author of the code.
Roy, are you listening?
Best regards,
Wolfgang Denk
On Fri, 2007-04-20 at 23:49, Wolfgang Denk wrote:
In message m2irbr3wou.fsf@sowhat.denx.de you wrote:
[snip]
while doing this noticed that the whole fixup only works because we have a maximum of one fixup entry (./drivers/tsi108_pci.c, I cannot find any user of addr_probe anywhere).
Tsi108/9 pci config read will introduce a exception. I do not see other exception after code relocation.
Otherwise the sorting of the
table is missing and thus the searching with a bisecting algorithm will not work as is.
Why?
I didn'tnotice this, I just cleaned up the compiler warning.
I am *really looking* forward to the patch fixing that :)
I am also.
Don't tell me, tell the author of the code.
Roy, are you listening?
Yes. I am listening. Roy
Hi Roy,
On Fri, 2007-04-20 at 23:49, Wolfgang Denk wrote:
In message m2irbr3wou.fsf@sowhat.denx.de you wrote:
[snip]
while doing this noticed that the whole fixup only works because we have a maximum of one fixup entry (./drivers/tsi108_pci.c, I cannot find any user of addr_probe anywhere).
Tsi108/9 pci config read will introduce a exception. I do not see other exception after code relocation.
Otherwise the sorting of the
table is missing and thus the searching with a bisecting algorithm will not work as is.
Why?
As I said, the search algorithm only works with a sorted table - just what "sort_main_extable" does in Linux. To be honest I did not look too hard but I couldn't find anything similar in U-Boot so the table will be unsorted and thus very likely fail if more entries are added.
So either sorting the table at some point or instead doing a linear search would fix the problems.
Cheers Detlev
On Mon, 2007-04-23 at 21:00, Detlev Zundel wrote:
Hi Roy,
[snip]
while doing this noticed that the whole fixup only works because
we
have a maximum of one fixup entry (./drivers/tsi108_pci.c, I
cannot
find any user of addr_probe anywhere).
Tsi108/9 pci config read will introduce a exception. I do not see
other
exception after code relocation.
Otherwise the sorting of the
table is missing and thus the searching with a bisecting
algorithm
will not work as is.
Why?
As I said, the search algorithm only works with a sorted table - just what "sort_main_extable" does in Linux. To be honest I did not look too hard but I couldn't find anything similar in U-Boot so the table will be unsorted and thus very likely fail if more entries are added.
Unsorted table will induce error for more entries. Until now, I can only see tsi108_pci.c adds exception item for the exception table. Other boards have empty addr_probe. They are commented out.
So either sorting the table at some point or instead doing a linear search would fix the problems.
I prefer the second. I will do some test on my board and give the patch. Thanks. Roy
participants (4)
-
Detlev Zundel -
Stefan Roese -
Wolfgang Denk -
Zang Roy-r61911