[PATCH] VIM3: mmc_get_env_dev correct non emmc boot sources
need return -1 if boot source is not EMMC or SD ( for example it will be useful if we have multy env sources configuration and device was booted from SPI flash and env need read from SPI not from mmc )
Signed-off-by: Artem Lapkin art@khadas.com --- board/amlogic/vim3/vim3.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 6cd5f2e1..71aaa0d8 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -19,9 +19,15 @@
int mmc_get_env_dev(void) { - if (meson_get_boot_device() == BOOT_DEVICE_EMMC) + switch (meson_get_boot_device()) { + case BOOT_DEVICE_EMMC: return 2; - return 1; + case BOOT_DEVICE_SD: + return 1; + default: + /* boot device is not EMMC|SD */ + return -1; + } }
/*
On 27/05/2021 09:35, Artem Lapkin wrote:
need return -1 if boot source is not EMMC or SD ( for example it will be useful if we have multy env sources configuration and device was booted from SPI flash and env need read from SPI not from mmc )
Signed-off-by: Artem Lapkin art@khadas.com
board/amlogic/vim3/vim3.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 6cd5f2e1..71aaa0d8 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -19,9 +19,15 @@
int mmc_get_env_dev(void) {
- if (meson_get_boot_device() == BOOT_DEVICE_EMMC)
- switch (meson_get_boot_device()) {
- case BOOT_DEVICE_EMMC: return 2;
- return 1;
- case BOOT_DEVICE_SD:
return 1;- default:
/* boot device is not EMMC|SD */return -1;- }
}
/*
Looks fine, I'll let other comment on it and apply it if it's ok for everyone,
Neil
On 5/27/21 4:35 PM, Artem Lapkin wrote:
need return -1 if boot source is not EMMC or SD ( for example it will be useful if we have multy env sources configuration and device was booted from SPI flash and env need read from SPI not from mmc )
Signed-off-by: Artem Lapkin art@khadas.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
board/amlogic/vim3/vim3.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 6cd5f2e1..71aaa0d8 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -19,9 +19,15 @@
int mmc_get_env_dev(void) {
- if (meson_get_boot_device() == BOOT_DEVICE_EMMC)
- switch (meson_get_boot_device()) {
- case BOOT_DEVICE_EMMC: return 2;
- return 1;
- case BOOT_DEVICE_SD:
return 1;- default:
/* boot device is not EMMC|SD */return -1;- }
}
/*
participants (3)
-
Artem Lapkin -
Jaehoon Chung -
Neil Armstrong