[U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame
From: zijun_hu zijun_hu@htc.com
relocate_code() allocates 32 bytes stack frame but only 16 bytes are freed before return. it will cause errors to possible previous frames and doesn't make relocate_code() look like a function.
fix by freeing 32 bytes stack space
Signed-off-by: zijun_hu zijun_hu@htc.com --- arch/arm/lib/relocate_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/relocate_64.S b/arch/arm/lib/relocate_64.S index c7600537063f..fdba004363af 100644 --- a/arch/arm/lib/relocate_64.S +++ b/arch/arm/lib/relocate_64.S @@ -73,6 +73,6 @@ relocate_done: isb sy 4: ldp x0, x1, [sp, #16] bl __asm_flush_dcache_range -5: ldp x29, x30, [sp],#16 +5: ldp x29, x30, [sp],#32 ret ENDPROC(relocate_code)
On 22 September 2017 at 23:30, zijun_hu zijun_hu@zoho.com wrote:
From: zijun_hu zijun_hu@htc.com
relocate_code() allocates 32 bytes stack frame but only 16 bytes are freed before return. it will cause errors to possible previous frames and doesn't make relocate_code() look like a function.
fix by freeing 32 bytes stack space
Signed-off-by: zijun_hu zijun_hu@htc.com
arch/arm/lib/relocate_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Sat, Sep 23, 2017 at 01:30:58PM +0800, zijun_hu wrote:
From: zijun_hu zijun_hu@htc.com
relocate_code() allocates 32 bytes stack frame but only 16 bytes are freed before return. it will cause errors to possible previous frames and doesn't make relocate_code() look like a function.
fix by freeing 32 bytes stack space
Signed-off-by: zijun_hu zijun_hu@htc.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Simon Glass -
Tom Rini -
zijun_hu