[PATCH 1/1] cmd: inconsistent return type of command_process()

The declarations in the header and in the implementation must match.
Reported-by: Sergei Antonov saproj@gmail.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- include/command.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/command.h b/include/command.h index 44c91f655d..8917da8b21 100644 --- a/include/command.h +++ b/include/command.h @@ -229,10 +229,10 @@ enum command_ret_t { * is left unchanged. * @param ticks If ticks is not null, this function set it to the * number of ticks the command took to complete. - * Return: 0 if the command succeeded, 1 if it failed + * Return: 0 if command succeeded, else non-zero (CMD_RET_...) */ -int cmd_process(int flag, int argc, char *const argv[], int *repeatable, - unsigned long *ticks); +enum command_ret_t cmd_process(int flag, int argc, char *const argv[], + int *repeatable, unsigned long *ticks);
void fixup_cmdtable(struct cmd_tbl *cmdtp, int size);

On Mon, 1 Aug 2022 at 07:18, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
The declarations in the header and in the implementation must match.
Reported-by: Sergei Antonov saproj@gmail.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
include/command.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org

On Mon, Aug 01, 2022 at 03:17:49PM +0200, Heinrich Schuchardt wrote:
The declarations in the header and in the implementation must match.
Reported-by: Sergei Antonov saproj@gmail.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Heinrich Schuchardt
-
Simon Glass
-
Tom Rini