[U-Boot] [PATCH 00/11] Add support for Synology DS414 and some related fixes
This patch series ultimately adds support for Synology DS414 NAS after a few fixes: * Patches 1-3 and 5 fix various files for enabled debugging. * Patch 4 updates the board porting guide in README file. * Patches 6-8 hold crucial fixes necessary for DS414 support. * Patches 9 and 10 contain the actual board support, split into a generic part for MV78230 SoC and a board specific part for clarity. * Patch 11 adds a new command to deal with Synology specialties.
In case you would like me to split this into multiple series, just let me know and I will resend.
Phil Sutter (11): drivers/pci: Fix for debug builds without CONFIG_PCI_ENUM_ONLY drivers/spi/kirkwood_spi: Fix debugging with CONFIG_DM_SPI mvebu: Fix for non-DM ehci-marvell support README: Review the u-boot porting guide list axp: Fix debugging support in DDR3 write leveling drivers/pci/pci_mvebu: Fix for boards with X4 lanes mvebu: Fix shortcoming of Marvell BSP board detection drivers/ddr/marvell: Default DRAM_ECC to 0 mvebu: Add rudimental MV78320 support mvebu: Support Synology DS414 common: Implement Synology specific command set
README | 11 +- arch/arm/Kconfig | 1 + arch/arm/dts/Makefile | 2 + arch/arm/dts/armada-xp-synology-ds414.dts | 330 +++++++++++++++++++++ arch/arm/mach-mvebu/Kconfig | 3 + arch/arm/mach-mvebu/cpu.c | 26 +- arch/arm/mach-mvebu/include/mach/cpu.h | 3 + arch/arm/mach-mvebu/include/mach/soc.h | 10 +- arch/arm/mach-mvebu/serdes/axp/board_env_spec.h | 5 +- .../arm/mach-mvebu/serdes/axp/high_speed_env_lib.c | 11 +- board/Synology/ds414/Kconfig | 12 + board/Synology/ds414/Makefile | 1 + board/Synology/ds414/ds414.c | 173 +++++++++++ board/Synology/ds414/kwbimage.cfg | 12 + common/Makefile | 1 + common/cmd_syno.c | 225 ++++++++++++++ configs/ds414_defconfig | 12 + drivers/ddr/marvell/axp/ddr3_axp_config.h | 2 +- drivers/ddr/marvell/axp/ddr3_write_leveling.c | 4 +- drivers/pci/pci_auto_old.c | 2 +- drivers/pci/pci_mvebu.c | 21 ++ drivers/spi/kirkwood_spi.c | 2 + include/configs/ds414.h | 154 ++++++++++ 23 files changed, 1006 insertions(+), 17 deletions(-) create mode 100644 arch/arm/dts/armada-xp-synology-ds414.dts create mode 100644 board/Synology/ds414/Kconfig create mode 100644 board/Synology/ds414/Makefile create mode 100644 board/Synology/ds414/ds414.c create mode 100644 board/Synology/ds414/kwbimage.cfg create mode 100644 common/cmd_syno.c create mode 100644 configs/ds414_defconfig create mode 100644 include/configs/ds414.h
Hi Phil,
(added Luka to Cc)
On 13.12.2015 01:29, Phil Sutter wrote:
This patch series ultimately adds support for Synology DS414 NAS after a few fixes:
- Patches 1-3 and 5 fix various files for enabled debugging.
- Patch 4 updates the board porting guide in README file.
- Patches 6-8 hold crucial fixes necessary for DS414 support.
- Patches 9 and 10 contain the actual board support, split into a generic part for MV78230 SoC and a board specific part for clarity.
- Patch 11 adds a new command to deal with Synology specialties.
In case you would like me to split this into multiple series, just let me know and I will resend.
Very nice to see other Armada XP based boards getting supported in mainline U-Boot. I'm currently also working on a new XP board based on the MV78260. And stumbled over a few of the problems you have met in your Armada XP support as well.
Since I'm currently preparing a new patchset for all this, including the full DM SPL support as well, perhaps it would be best, if you base your MV78230 work in top of my new patches. I will send the new patches to the list later today. And will also publish a git branch for easier work with it. Since there are some dependencies with other patches as well.
BTW: With this work you should be able to drop all those "non-DM" patches from your series.
Thanks, Stefan
PS: Please keep Luka and me on Cc on all mvebu related patches.
Hi Stefan,
On Mon, Dec 14, 2015 at 08:38:06AM +0100, Stefan Roese wrote:
On 13.12.2015 01:29, Phil Sutter wrote:
This patch series ultimately adds support for Synology DS414 NAS after a few fixes:
- Patches 1-3 and 5 fix various files for enabled debugging.
- Patch 4 updates the board porting guide in README file.
- Patches 6-8 hold crucial fixes necessary for DS414 support.
- Patches 9 and 10 contain the actual board support, split into a generic part for MV78230 SoC and a board specific part for clarity.
- Patch 11 adds a new command to deal with Synology specialties.
In case you would like me to split this into multiple series, just let me know and I will resend.
Very nice to see other Armada XP based boards getting supported in mainline U-Boot. I'm currently also working on a new XP board based on the MV78260. And stumbled over a few of the problems you have met in your Armada XP support as well.
Since I'm currently preparing a new patchset for all this, including the full DM SPL support as well, perhaps it would be best, if you base your MV78230 work in top of my new patches. I will send the new patches to the list later today. And will also publish a git branch for easier work with it. Since there are some dependencies with other patches as well.
Sounds very good, I'm looking forward to seeing how you solved things and how that combines with my stuff.
BTW: With this work you should be able to drop all those "non-DM" patches from your series.
Nice!
PS: Please keep Luka and me on Cc on all mvebu related patches.
Will do.
Thanks, Phil
Hi Phil,
(added Dennis, as he is also interested in this new git branch)
On 14.12.2015 12:26, Phil Sutter wrote:
On Mon, Dec 14, 2015 at 08:38:06AM +0100, Stefan Roese wrote:
On 13.12.2015 01:29, Phil Sutter wrote:
This patch series ultimately adds support for Synology DS414 NAS after a few fixes:
- Patches 1-3 and 5 fix various files for enabled debugging.
- Patch 4 updates the board porting guide in README file.
- Patches 6-8 hold crucial fixes necessary for DS414 support.
- Patches 9 and 10 contain the actual board support, split into a generic part for MV78230 SoC and a board specific part for clarity.
- Patch 11 adds a new command to deal with Synology specialties.
In case you would like me to split this into multiple series, just let me know and I will resend.
Very nice to see other Armada XP based boards getting supported in mainline U-Boot. I'm currently also working on a new XP board based on the MV78260. And stumbled over a few of the problems you have met in your Armada XP support as well.
Since I'm currently preparing a new patchset for all this, including the full DM SPL support as well, perhaps it would be best, if you base your MV78230 work in top of my new patches. I will send the new patches to the list later today. And will also publish a git branch for easier work with it. Since there are some dependencies with other patches as well.
Sounds very good, I'm looking forward to seeing how you solved things and how that combines with my stuff.
BTW: With this work you should be able to drop all those "non-DM" patches from your series.
Nice!
PS: Please keep Luka and me on Cc on all mvebu related patches.
Will do.
Thanks.
Okay. I've sent the new patches to the list. And also added a branch to the "u-boot-a38x.git" gitlab repository. You can find a full working version in this branch now "mvebu-dm-spl-2015-12-14":
https://gitlab.denx.de/sr/u-boot-a38x/commits/mvebu-dm-spl-2015-12-14
Please base your work on top of this branch if possible. Adding support for your MV78230 should be quite straight forward now.
Just let me know if you have any questions.
@ Dennis: This branch also includes the latest version for the ClearFog. Please take a look at it and let me know if it works for you.
Thanks, Stefan
Hi Stefan,
On Mon, Dec 14, 2015 at 01:06:07PM +0100, Stefan Roese wrote:
Okay. I've sent the new patches to the list. And also added a branch to the "u-boot-a38x.git" gitlab repository. You can find a full working version in this branch now "mvebu-dm-spl-2015-12-14":
https://gitlab.denx.de/sr/u-boot-a38x/commits/mvebu-dm-spl-2015-12-14
Please base your work on top of this branch if possible. Adding support for your MV78230 should be quite straight forward now.
After skimming through your patches, I'm quite convinced it will be.
Thanks, Phil
Hi Phil,
On 14.12.2015 15:03, Phil Sutter wrote:
On Mon, Dec 14, 2015 at 01:06:07PM +0100, Stefan Roese wrote:
Okay. I've sent the new patches to the list. And also added a branch to the "u-boot-a38x.git" gitlab repository. You can find a full working version in this branch now "mvebu-dm-spl-2015-12-14":
https://gitlab.denx.de/sr/u-boot-a38x/commits/mvebu-dm-spl-2015-12-14
Please base your work on top of this branch if possible. Adding support for your MV78230 should be quite straight forward now.
After skimming through your patches, I'm quite convinced it will be.
One thing to note: Please make sure to add the "u-boot,dm-pre-reloc;" properties to the device-tree nodes that are used in the SPL. So especially the UART and perhaps the SPI NOR (not sure your board boots from this device) need these properties. And also, please check that you have the defconfig from the new branch as a a basis for your board port.
Thanks, Stefan
participants (2)
-
Phil Sutter -
Stefan Roese