[U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef'
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to undef an option that is not enabled by default.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 4e70617..b677e51 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -215,7 +215,6 @@ #define CONFIG_SF_DEFAULT_SPEED 24000000
/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH #ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
From: Fabio Estevam fabio.estevam@freescale.com
commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.
Fix it, so that the following warning goes away:
mx28evk.c: In function ‘dram_init’: mx28evk.c:67:2: warning: implicit declaration of function ‘mx28_dram_init’ [-Wimplicit-function-declaration]
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h index 9d1e599..4610363 100644 --- a/arch/arm/include/asm/arch-mxs/sys_proto.h +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h @@ -69,6 +69,6 @@ struct mxs_spl_data { uint32_t mem_dram_size; };
-int mxs_dram_init(void); +int mx28_dram_init(void);
#endif /* __SYS_PROTO_H__ */
Dear Fabio Estevam,
From: Fabio Estevam fabio.estevam@freescale.com
commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.
Fix it, so that the following warning goes away:
mx28evk.c: In function ‘dram_init’: mx28evk.c:67:2: warning: implicit declaration of function ‘mx28_dram_init’ [-Wimplicit-function-declaration]
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h index 9d1e599..4610363 100644 --- a/arch/arm/include/asm/arch-mxs/sys_proto.h +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h @@ -69,6 +69,6 @@ struct mxs_spl_data { uint32_t mem_dram_size; };
-int mxs_dram_init(void); +int mx28_dram_init(void);
#endif /* __SYS_PROTO_H__ */
Acked-by: Marek Vasut marex@denx.de
Best regards, Marek Vasut
On Sat, Aug 18, 2012 at 8:28 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.
Fix it, so that the following warning goes away:
mx28evk.c: In function ‘dram_init’: mx28evk.c:67:2: warning: implicit declaration of function ‘mx28_dram_init’ [-Wimplicit-function-declaration]
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Otavio Salvador otavio@ossystems.com.br
Hi Stefano,
On Sat, Aug 18, 2012 at 8:28 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.
Fix it, so that the following warning goes away:
mx28evk.c: In function ‘dram_init’: mx28evk.c:67:2: warning: implicit declaration of function ‘mx28_dram_init’ [-Wimplicit-function-declaration]
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Please discard this patch.
Otavio fixed it in another patch related to mx23 series.
Regards,
Fabio Estevam
On Sun, Aug 19, 2012 at 12:33 PM, Fabio Estevam festevam@gmail.com wrote:
Please discard this patch.
Otavio fixed it in another patch related to mx23 series.
Ops, sorry. Otavio based his patch on top of mine, so this one needs to be applied.
Thanks,
Fabio Estevam
On Sun, Aug 19, 2012 at 12:36 PM, Fabio Estevam festevam@gmail.com wrote:
On Sun, Aug 19, 2012 at 12:33 PM, Fabio Estevam festevam@gmail.com wrote:
Please discard this patch.
Otavio fixed it in another patch related to mx23 series.
Ops, sorry. Otavio based his patch on top of mine, so this one needs to be applied.
It shouldn't matter; GIT will do a 3way merge and apply I think.
On 19/08/2012 01:28, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.
Fix it, so that the following warning goes away:
mx28evk.c: In function ‘dram_init’: mx28evk.c:67:2: warning: implicit declaration of function ‘mx28_dram_init’ [-Wimplicit-function-declaration]
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h index 9d1e599..4610363 100644 --- a/arch/arm/include/asm/arch-mxs/sys_proto.h +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h @@ -69,6 +69,6 @@ struct mxs_spl_data { uint32_t mem_dram_size; };
-int mxs_dram_init(void); +int mx28_dram_init(void);
#endif /* __SYS_PROTO_H__ */
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
Dear Fabio Estevam,
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to undef an option that is not enabled by default.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 4e70617..b677e51 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -215,7 +215,6 @@ #define CONFIG_SF_DEFAULT_SPEED 24000000
/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH #ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
Acked-by: Marek Vasut marex@denx.de
Best regards, Marek Vasut
On 19/08/2012 01:28, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to undef an option that is not enabled by default.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 4e70617..b677e51 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -215,7 +215,6 @@ #define CONFIG_SF_DEFAULT_SPEED 24000000
/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH #ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
Acked-by: Stefano Babic sbabic@denx.de
Regards, Stefano
On 19/08/2012 01:28, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to undef an option that is not enabled by default.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 4e70617..b677e51 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -215,7 +215,6 @@ #define CONFIG_SF_DEFAULT_SPEED 24000000
/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH #ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
participants (4)
-
Fabio Estevam -
Marek Vasut -
Otavio Salvador -
Stefano Babic