[U-Boot] [PATCH] omap3logic: Fix PBIAS Bug

From: Adam Ford aford173@gmail.com
The PBIAS fixing is done in the MMC driver, and doing it in the the board file conflicts with the driver causing intermittent hangs on reboot. Remove this from the board file and let the driver do it.
Signed-off-by: Adam Ford aford173@gmail.com
diff --git a/board/logicpd/omap3som/omap3logic.c b/board/logicpd/omap3som/omap3logic.c index 51d2987..c2bb730 100644 --- a/board/logicpd/omap3som/omap3logic.c +++ b/board/logicpd/omap3som/omap3logic.c @@ -144,20 +144,8 @@ static struct musb_hdrc_platform_data musb_plat = { */ int misc_init_r(void) { - t2_t *t2_base = (t2_t *)T2_BASE; - u32 pbias_lite; - /* set up dual-voltage GPIOs to 1.8V */ - pbias_lite = readl(&t2_base->pbias_lite); - pbias_lite &= ~PBIASLITEVMODE1; - pbias_lite |= PBIASLITEPWRDNZ1; - writel(pbias_lite, &t2_base->pbias_lite); - if (get_cpu_family() == CPU_OMAP36XX) - writel(readl(CONTROL_WKUP_CTRL) | GPIO_IO_PWRDNZ, - CONTROL_WKUP_CTRL); twl4030_power_init(); - omap_die_id_display(); - putc('\n');
#ifdef CONFIG_USB_MUSB_OMAP2PLUS musb_register(&musb_plat, &musb_board_data, (void *)MUSB_BASE);

On Fri, Aug 26, 2016 at 07:53:53AM -0500, aford173@gmail.com wrote:
From: Adam Ford aford173@gmail.com
The PBIAS fixing is done in the MMC driver, and doing it in the the board file conflicts with the driver causing intermittent hangs on reboot. Remove this from the board file and let the driver do it.
Signed-off-by: Adam Ford aford173@gmail.com
diff --git a/board/logicpd/omap3som/omap3logic.c b/board/logicpd/omap3som/omap3logic.c index 51d2987..c2bb730 100644
Reviewed-by: Tom Rini trini@konsulko.com

On Fri, Aug 26, 2016 at 07:53:53AM -0500, Adam Ford wrote:
From: Adam Ford aford173@gmail.com
The PBIAS fixing is done in the MMC driver, and doing it in the the board file conflicts with the driver causing intermittent hangs on reboot. Remove this from the board file and let the driver do it.
Signed-off-by: Adam Ford aford173@gmail.com Reviewed-by: Tom Rini trini@konsulko.com
diff --git a/board/logicpd/omap3som/omap3logic.c b/board/logicpd/omap3som/omap3logic.c index 51d2987..c2bb730 100644
Applied to u-boot/master, thanks!
participants (2)
-
aford173@gmail.com
-
Tom Rini