[U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL
From: Tien Fong Chee tien.fong.chee@intel.com
CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB memory.
Signed-off-by: Tien Fong Chee tien.fong.chee@intel.com --- fs/fs.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c index 0b8088b..252e2f5 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = { .closedir = fat_closedir, }, #endif -#ifdef CONFIG_FS_EXT4 +/* #ifdef CONFIG_FS_EXT4 */ +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \ + (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT)) { .fstype = FS_TYPE_EXT, .name = "ext4",
On Thu, Jan 17, 2019 at 03:01:49PM +0800, tien.fong.chee@intel.com wrote:
From: Tien Fong Chee tien.fong.chee@intel.com
CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB memory.
Signed-off-by: Tien Fong Chee tien.fong.chee@intel.com
fs/fs.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c index 0b8088b..252e2f5 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = { .closedir = fat_closedir, }, #endif -#ifdef CONFIG_FS_EXT4 +/* #ifdef CONFIG_FS_EXT4 */ +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
- (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT)) { .fstype = FS_TYPE_EXT, .name = "ext4",
This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2 patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!
On Thu, 2019-01-17 at 07:23 -0500, Tom Rini wrote:
On Thu, Jan 17, 2019 at 03:01:49PM +0800, tien.fong.chee@intel.com wrote:
From: Tien Fong Chee tien.fong.chee@intel.com
CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB memory.
Signed-off-by: Tien Fong Chee tien.fong.chee@intel.com
fs/fs.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c index 0b8088b..252e2f5 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = { .closedir = fat_closedir, }, #endif -#ifdef CONFIG_FS_EXT4 +/* #ifdef CONFIG_FS_EXT4 */ +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
- (defined(CONFIG_SPL_BUILD) &&
defined(CONFIG_SPL_EXT_SUPPORT)) { .fstype = FS_TYPE_EXT, .name = "ext4",
This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2 patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!
Okay.
participants (3)
-
Chee, Tien Fong -
tien.fong.chee＠intel.com
-
Tom Rini